[18.0][FIX] stock_picking_batch_creation: fix stock device order #2160
+67
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @lmignon, |
Contributor
|
no need to update tests? |
Before this change when searching for a device to use for the batch, the order of the devices was not guaranteed although important. And it could cause some batch split not happening. Now the possible devices will be sorted by their default order, which is by sequence and name.
TDu
force-pushed
the
18-stock-picking-batch-creation-force-device-order
branch
from
305181b to
d469448
Compare
Member
Author
I have added 2 in relation to the changes |
lmignon
reviewed
Nov 12, 2025
|
|
||
| def _split_first_picking_for_limit(self, picking): | ||
| last_device = self.stock_device_type_ids[-1] | ||
| last_device = self.stock_device_type_ids.sorted()[-1] |
Contributor
There was a problem hiding this comment.
We could use a method to get the list of devices in order to centralize the required logic to ensure the right order etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change when searching for a device to use for the batch, the order of the devices was not guaranteed although important. And it could cause some batch split not happening.
Now the possible devices will be sorted by their default order, which is by sequence and name.