Skip to content

Conversation

@Andrii9090
Copy link

@Andrii9090 Andrii9090 commented Nov 12, 2025

Straightforward migration to v18

I should make some minor changes.

In v18, there is no qty_done field in stock.move.line. According to this commit in Odoo 18, quantity is used

Now in Odoo not exist the view stock.view_stock_move_nosuggest_operations, this method action_show_details set a view stock.view_stock_move_operations

A method _get_move_lines in Odoo 18 no longer exists and has been replaced by the move_line_ids field (Row 246)

https://www.loom.com/share/6e351e8626d84428a7c33f0593f5134a

MT-11842
@moduon

Shide and others added 11 commits November 11, 2025 16:26
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_expiration_date_required
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_expiration_date_required/it/
…field definition

Using the required on the field definition causes the database to set "not nullable" on expiry_date column on stock.move.line.
Moved the required to the views.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_expiration_date_required
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_expiration_date_required/
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_expiration_date_required
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_expiration_date_required/it/
@Andrii9090 Andrii9090 marked this pull request as draft November 12, 2025 12:23
@Andrii9090 Andrii9090 marked this pull request as ready for review November 12, 2025 13:58
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Good job!

Copy link
Contributor

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Andrii9090 !
The following tests have been executed successfully.

  • Test 1: Verified mandatory manual expiration date for products with 0-day expiration time; system correctly blocked saving and validation until the date was filled.
  • Test 2: Confirmed automatic expiration date calculation when expiration_time > 0; lines were populated with the correct computed date.
  • Test 3: Checked serial generation with expiration_time = 0; serials were created without expiration date and validation was correctly blocked.
  • Test 4: Confirmed automatic expiration date assignment during serial generation when expiration_time > 0; validation succeeded without manual input.
  • Test 5: Ensured products without expiration control behaved normally; no date required and validation completed.
  • Test 6: Validated mixed picking behavior; only caducable products blocked validation, and completing their expiration date allowed successful confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants