-
-
Notifications
You must be signed in to change notification settings - Fork 729
[18.0][MIG] stock_move_line_expiration_date_required: Migration to 18 #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andrii9090
wants to merge
11
commits into
OCA:18.0
Choose a base branch
from
moduon:18.0-mig-stock_move_line_expiration_date_required
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] stock_move_line_expiration_date_required: Migration to 18 #2164
Andrii9090
wants to merge
11
commits into
OCA:18.0
from
moduon:18.0-mig-stock_move_line_expiration_date_required
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_expiration_date_required Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_expiration_date_required/it/
…field definition Using the required on the field definition causes the database to set "not nullable" on expiry_date column on stock.move.line. Moved the required to the views.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_expiration_date_required Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_expiration_date_required/
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_expiration_date_required Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_expiration_date_required/it/
chienandalu
approved these changes
Nov 12, 2025
Member
chienandalu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Good job!
Gelojr
approved these changes
Nov 13, 2025
Contributor
Gelojr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Andrii9090 !
The following tests have been executed successfully.
- Test 1: Verified mandatory manual expiration date for products with 0-day expiration time; system correctly blocked saving and validation until the date was filled.
- Test 2: Confirmed automatic expiration date calculation when expiration_time > 0; lines were populated with the correct computed date.
- Test 3: Checked serial generation with expiration_time = 0; serials were created without expiration date and validation was correctly blocked.
- Test 4: Confirmed automatic expiration date assignment during serial generation when expiration_time > 0; validation succeeded without manual input.
- Test 5: Ensured products without expiration control behaved normally; no date required and validation completed.
- Test 6: Validated mixed picking behavior; only caducable products blocked validation, and completing their expiration date allowed successful confirmation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward migration to v18
I should make some minor changes.
In v18, there is no
qty_donefield instock.move.line. According to this commit in Odoo 18,quantityis usedNow in Odoo not exist the view
stock.view_stock_move_nosuggest_operations, this method action_show_details set a viewstock.view_stock_move_operationsA method
_get_move_linesin Odoo 18 no longer exists and has been replaced by themove_line_idsfield (Row 246)https://www.loom.com/share/6e351e8626d84428a7c33f0593f5134a
MT-11842
@moduon