[18.0][FIX] web_pivot_computed_measure: fix fake fields in tests

Author: kobros-tech

web_pivot_computed_measure/README.rst

@@ -109,6 +109,10 @@ Contributors
   - Ernesto Tejeda
   - Carlos Roca
 
+- `Kencove <https://www.kencove.com/>`__:
+
+  - Mohamed Alkobrosli
+
 Maintainers
 -----------
 

web_pivot_computed_measure/readme/CONTRIBUTORS.md

@@ -3,3 +3,7 @@
   - Pedro M. Baeza
   - Ernesto Tejeda
   - Carlos Roca
+
+- [Kencove](https://www.kencove.com/):
+  - Mohamed Alkobrosli
+  

web_pivot_computed_measure/static/description/index.html

@@ -460,6 +460,10 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Carlos Roca</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://www.kencove.com/">Kencove</a>:<ul>
+<li>Mohamed Alkobrosli</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

web_pivot_computed_measure/static/src/pivot/pivot_model.esm.js

@@ -1,3 +1,4 @@
+/* global console */
 /* Copyright 2020 Tecnativa - Alexandre Díaz
  * Copyright 2022 Tecnativa - Carlos Roca
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html) */
@@ -40,18 +41,24 @@ patch(PivotModel.prototype, {
         if (measure) {
             return Promise.resolve();
         }
-        const fieldM1 = this.metaData.fields[field1];
-        const fieldM2 = this.metaData.fields[field2];
+        const fieldM1 = this.metaData.fields?.[field1];
+        const fieldM2 = this.metaData.fields?.[field2];
+
+        if (!fieldM1 || !fieldM2) {
+            console.error(`Invalid fields: field1=${field1}, field2=${field2}`);
+            return Promise.reject(new Error("Invalid computed measure fields."));
+        }
+
         const cmId = "__computed_" + id;
         const oper = operation.replace(/m1/g, field1).replace(/m2/g, field2);
         const oper_human = operation
             .replace(
                 /m1/g,
-                fieldM1.__computed_id ? "(" + fieldM1.string + ")" : fieldM1.string
+                fieldM1.__computed_id ? "(" + fieldM1?.string + ")" : fieldM1?.string
             )
             .replace(
                 /m2/g,
-                fieldM2.__computed_id ? "(" + fieldM2.string + ")" : fieldM2.string
+                fieldM2.__computed_id ? "(" + fieldM2?.string + ")" : fieldM2?.string
             );
         const cmTotal = this._computed_measures.push({
             field1: field1,

web_pivot_computed_measure/tests/res_users_fake.py

@@ -1,6 +1,5 @@
 # Copyright 2022 Tecnativa - Carlos Roca
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
-from odoo_test_helper import FakeModelLoader
 
 from odoo.tests import common, tagged
 
@@ -10,18 +9,41 @@ class TestUIPivot(common.HttpCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.loader = FakeModelLoader(cls.env, cls.__module__)
-        cls.loader.backup_registry()
-        from .res_users_fake import ResUsersFake
 
-        cls.loader.update_registry((ResUsersFake,))
+        res_users_model_id = (
+            cls.env["ir.model"].search([("model", "=", "res.users")]).id
+        )
+        cls.env["ir.model.fields"].create(
+            {
+                "name": "x_user_year_born",
+                "model": "res.users",
+                "field_description": "Year Born",
+                "ttype": "integer",
+                "store": False,
+                "model_id": res_users_model_id,
+            }
+        )
+        cls.env["ir.model.fields"].create(
+            {
+                "name": "x_user_year_now",
+                "model": "res.users",
+                "field_description": "Year Born",
+                "ttype": "integer",
+                "store": False,
+                "model_id": res_users_model_id,
+            }
+        )
+        cls.env.registry.setup_models(cls.env.cr)
+        cls.env.registry.init_models(
+            cls.env.cr, ["res.users"], {"update_custom_fields": True}
+        )
         cls.env["res.users"].create(
             {
                 "name": "User 1",
                 "login": "us_1",
                 # Fake fields
-                "user_year_born": 1998,
-                "user_year_now": 2022,
+                "x_user_year_born": 1998,
+                "x_user_year_now": 2022,
             }
         )
         # Set pivot view to company action