Skip to content

Commit 5309f7f

Browse files
committed
change some properties
1 parent 00342e0 commit 5309f7f

File tree

2 files changed

+8
-29
lines changed

2 files changed

+8
-29
lines changed

src/Microsoft.AspNetCore.OData/Results/CreatedODataResult.cs

+5-18
Original file line numberDiff line numberDiff line change
@@ -20,32 +20,19 @@ namespace Microsoft.AspNetCore.OData.Results
2020
/// generates an OData-EntityId header.</remarks>
2121
public class CreatedODataResult<T> : ActionResult
2222
{
23-
private readonly T _innerResult;
24-
2523
/// <summary>
2624
/// Initializes a new instance of the <see cref="CreatedODataResult{T}"/> class.
2725
/// </summary>
2826
/// <param name="entity">The created entity.</param>
2927
public CreatedODataResult(T entity)
3028
{
31-
if (entity == null)
32-
{
33-
throw Error.ArgumentNull(nameof(entity));
34-
}
35-
36-
this._innerResult = entity;
29+
Entity = entity ?? throw Error.ArgumentNull(nameof(entity));
3730
}
3831

3932
/// <summary>
4033
/// Gets the entity that was created.
4134
/// </summary>
42-
public virtual T Entity
43-
{
44-
get
45-
{
46-
return _innerResult;
47-
}
48-
}
35+
public virtual T Entity { get; }
4936

5037
/// <inheritdoc/>
5138
public async override Task ExecuteResultAsync(ActionContext context)
@@ -76,7 +63,7 @@ internal IActionResult GetInnerActionResult(HttpRequest request)
7663
}
7764
else
7865
{
79-
ObjectResult objectResult = new ObjectResult(_innerResult)
66+
ObjectResult objectResult = new ObjectResult(Entity)
8067
{
8168
StatusCode = StatusCodes.Status201Created
8269
};
@@ -88,13 +75,13 @@ internal IActionResult GetInnerActionResult(HttpRequest request)
8875
// internal just for unit test.
8976
internal Uri GenerateEntityId(HttpRequest request)
9077
{
91-
return ResultHelpers.GenerateODataLink(request, _innerResult, isEntityId: true);
78+
return ResultHelpers.GenerateODataLink(request, Entity, isEntityId: true);
9279
}
9380

9481
// internal just for unit test.
9582
internal Uri GenerateLocationHeader(HttpRequest request)
9683
{
97-
return ResultHelpers.GenerateODataLink(request, _innerResult, isEntityId: false);
84+
return ResultHelpers.GenerateODataLink(request, Entity, isEntityId: false);
9885
}
9986
}
10087
}

src/Microsoft.AspNetCore.OData/Results/UpdatedODataResult.cs

+3-11
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,19 @@ namespace Microsoft.AspNetCore.OData.Results
1818
/// <remarks>This action result handles content negotiation and the HTTP prefer header.</remarks>
1919
public class UpdatedODataResult<T> : ActionResult
2020
{
21-
private readonly T _innerResult;
22-
2321
/// <summary>
2422
/// Initializes a new instance of the <see cref="UpdatedODataResult{T}"/> class.
2523
/// </summary>
2624
/// <param name="entity">The updated entity.</param>
2725
public UpdatedODataResult(T entity)
2826
{
29-
this._innerResult = entity ?? throw new ArgumentNullException(nameof(entity));
27+
Entity = entity ?? throw new ArgumentNullException(nameof(entity));
3028
}
3129

3230
/// <summary>
3331
/// Gets the entity that was updated.
3432
/// </summary>
35-
public virtual T Entity
36-
{
37-
get
38-
{
39-
return _innerResult;
40-
}
41-
}
33+
public virtual T Entity { get; }
4234

4335
/// <inheritdoc/>
4436
public async override Task ExecuteResultAsync(ActionContext context)
@@ -59,7 +51,7 @@ internal IActionResult GetInnerActionResult(HttpRequest request)
5951
{
6052
if (RequestPreferenceHelpers.RequestPrefersReturnContent(request.Headers))
6153
{
62-
ObjectResult objectResult = new ObjectResult(_innerResult)
54+
ObjectResult objectResult = new ObjectResult(Entity)
6355
{
6456
StatusCode = StatusCodes.Status200OK
6557
};

0 commit comments

Comments
 (0)