Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add utility to change color of SVG #26

Open
tomkralidis opened this issue Mar 3, 2015 · 4 comments
Open

add utility to change color of SVG #26

tomkralidis opened this issue Mar 3, 2015 · 4 comments
Assignees
Labels
enhancement V1.1 Backwards compatible improvements
Milestone

Comments

@tomkralidis
Copy link
Member

Looks like we have defaults of:

  • stroke:#000000
  • fill:#000000

Add a utility which allows the user to specify a hex, rgb, or color to update an SVG.

@tomkralidis tomkralidis self-assigned this Mar 3, 2015
@tomkralidis tomkralidis added this to the 1.0.0 milestone Mar 3, 2015
@wxtim
Copy link

wxtim commented Jan 31, 2019

@tomkralidis - have you done anything with this?

@tomkralidis
Copy link
Member Author

@wxtim nothing to date. We could prioritize if required.

@chris-little
Copy link
Member

chris-little commented Oct 14, 2021

@tomkralidis @wxtim Apologies for not visiting here for many years!
I think styles are important. The original intent was to support both the monochrome and the bi-colour version of the symbols, as specificed by WMO and ICAO.
The context has changed slightly, in that SVG2.0 has clarified its relationship with surrounding web pages and CSS, etc., so there may be a requirement to inherit styles from the context. However, as the orginal design was to support viewing in low level light, or red light, and on low resolution devices, many acessibility have already been addressed.

Also, black and red are still the only readily available, non-poisonous, archival inks, thus addressing another requirement.

The only reason for not implementing the bi-colour and monochrome options was uncertainty on the best approach and what the market supported.

I am open to the way forward on this issue.

@chris-little
Copy link
Member

PErhaps this is two issues:

  1. Support non-black symbols;

  2. support bicolour symbols as per WMO / OMM definitions

@chris-little chris-little added the V1.1 Backwards compatible improvements label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement V1.1 Backwards compatible improvements
Projects
None yet
Development

No branches or pull requests

3 participants