Skip to content

Bug fix and small improvement #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bug fix and small improvement #412

wants to merge 2 commits into from

Conversation

matsvanes
Copy link
Collaborator

Fixes ica_label, and added an mne wrapper to preprocessing module for interpolating bad channels (with reset_bads=False by default - needed to keep track of bad channels)

@matsvanes
Copy link
Collaborator Author

Actually, it might be better to find another workaround for interpolate_bads.. Because it reset_bads=False, it might affect functionality going forward (i.e., if only good channels are selected). What do you think @cgohil8 ?

@cgohil8
Copy link
Collaborator

cgohil8 commented Jul 17, 2025

How come we have to set this to False now when before it defaulted to True. Was there always a bug or did something else change so we need to pass reset_bads=False? I think the main questions are:

  • How does it affect the ICA? We don't want bad channels to be included.
  • How does it affect the covariance calculation in the source reconstruction? I actually can't recall how bad channels are dealt with, i think it just includes everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants