Spanish Language Leader

[mardito]

Hi team!
It would be an honor for me to help in the Spanish translation of Home Assistant.

[barrowghoul]

Hi HASS team I´ve been a HASS user for a couple of years and I´d really like to help you on this new project.

[cibernox]

Same for me, I can help with Spanish. I have developed custom Alexa integrations in the past, so I've learned a bit in about intents. I can also do the same for Galician.

I think that we should have people helping to oversee the most important variants of Spanish. Castilian, Mexican and Argentinian+Uruguayan at least.

[synesthesiam]

@davefx, @jfisbein - continuing discussion of Spanish language leader(s) here.

[jfisbein]

I can help with Spanish translation, I'm Spanish and backend developer.

[slepiavka]

Not sure if I'm helping or bloating the discussion at this point, but I'm happy to take as much leadership as needed in Spanish.

[cibernox]

While no formal leader is appointed, I thought I should bring attention over these open PRs, on of which I've just opened. We can works as a committee in the meantime.

https://github.com/home-assistant/intents/pulls?q=is%3Apr+is%3Aopen+label%3A%22lang%3A+es%22

[jfisbein]

I just reviewed the #225 PR.

Side question: Should we switch this discussion to spanish?

[jfisbein]

None of the PR for Spanish is passing the tests 😞.
I reviewed thousands of PRs in my life, but it's the first time I review PR in an open-source project.

How do you think we should proceed?
Ask the submitter to modify it until it passes the tests?
Fix ourselves to make it pass the tests?
Find the cause and explain to the submitter what they should change to pass the tests?

[cibernox]

@jfisbein Usually on open source projects PRs reviewers only give feedback and it's the person who opened the PRs who make the changes. Unless that person explicitly asks for help of course.

Tests must pass for a PR to be merged, 100%.

[barrowghoul]

Hey guys, who should approve the access in order to be able to push branches to the github repo?

[cibernox]

@barrowghoul nobody puches branches to this repo I believe, everybody must fork it and create PRs from the fork.

[synesthesiam]

I'll try to help get some PRs merged. In the future, the language leader(s) will be able to merge PRs once the tests pass.

[miguelarios]

Hi guys I'm a Mexican and been a HA user for years. The Spanish language is a passion for me being in tech as a product manager I have worked in both languages both professionally and personally so I can try to make sure colloquially we are spot on. I can take care of the Mexican side of things.

[davefx]

@miguelarios : could you please take a look at the sentences in the folder https://github.com/davefx/intents/tree/patch-1/tests/es to see if there's any missing verb or sentence that you would use in Mexico and/or other Spanish-speaking countries from America?

[alexiri]

I'd also be happy to help if needed.

[davefx]

I just updated my PR #225 adding all the proposed suggestions and changes. Let's see if it passes tests now... BTW, I would be happy to be the Spanish Language Leader. I have wide experience translating open source documentation and software. -- David Marín Carreño ***@***.***> El dom, 8 ene 2023 a las 23:12, Alex Iribarren ***@***.***>) escribió:

…

I'd also be happy to help if needed. — Reply to this email directly, view it on GitHub <#356 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHLVPM4GGF4E33TUP3O6TWRM3TXANCNFSM6AAAAAATSFFXHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[davefx]

I've just corrected and added *LOTS* of missing tests for all the added synonyms to my PR (#225) Is anyone able to launch the tests for this branch? I think now they should work. -- David Marín Carreño ***@***.***> El lun, 9 ene 2023 a las 13:44, David Marín Carreño ***@***.***>) escribió:

…

I just updated my PR #225 adding all the proposed suggestions and changes. Let's see if it passes tests now... BTW, I would be happy to be the Spanish Language Leader. I have wide experience translating open source documentation and software. -- David Marín Carreño ***@***.***> El dom, 8 ene 2023 a las 23:12, Alex Iribarren ***@***.***>) escribió: > I'd also be happy to help if needed. > > — > Reply to this email directly, view it on GitHub > <#356 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACHLVPM4GGF4E33TUP3O6TWRM3TXANCNFSM6AAAAAATSFFXHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[cibernox]

@davefx if you have availability I'm cool with you being language leader, the most important thing is to get this going ASAP.

[davefx]

Yes, I confirm I have availability for this.

[synesthesiam]

Thanks @davefx! Adding you as language leader.

[synesthesiam]

@davefx when you get a chance, please look into the translations for HassGetState

[davefx]

Working on it...

[miguelarios]

Sorry about taking so long at this. I'll carve out time for this. I did look at it briefly and had some suggestions. Should I make a PR or just start with an issue?El ene. 9, 2023, a la(s) 7:48 a.m., David Marín ***@***.***> escribió: @miguelarios : could you please take a look at the sentences in the folder https://github.com/davefx/intents/tree/patch-1/tests/es to see if there's any missing verb or sentence that you would use in Mexico and/or other Spanish-speaking countries from America? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[davefx]

Please create a PR directly. Thanks! -- David Marín Carreño ***@***.***> El mié, 22 feb 2023 a las 15:09, Miguel R ***@***.***>) escribió:

…

Sorry about taking so long at this. I'll carve out time for this. I did look at it briefly and had some suggestions. Should I make a PR or just start with an issue?El ene. 9, 2023, a la(s) 7:48 a.m., David Marín ***@***.***> escribió: @miguelarios : could you please take a look at the sentences in the folder https://github.com/davefx/intents/tree/patch-1/tests/es to see if there's any missing verb or sentence that you would use in Mexico and/or other Spanish-speaking countries from America? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> — Reply to this email directly, view it on GitHub <#356 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHLVJRUUH5CLX4R53ETUDWYYMY7ANCNFSM6AAAAAATSFFXHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>