Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Instances of one series are splitted #4416

Open
narbek-abd opened this issue Oct 11, 2024 · 3 comments
Open

[Bug] Instances of one series are splitted #4416

narbek-abd opened this issue Oct 11, 2024 · 3 comments
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@narbek-abd
Copy link

Describe the Bug

028bd0c0-4e389405-e7476fe9-1c31fff6-1306d902.zip
Here is anonymized study.

image
They are in the same series, but splitted

Steps to Reproduce

tried open on last version and on 3.7

The current behavior

splitted

The expected behavior

Expected instances to be in the same series so i could scroll in single viewer

OS

all

Node version

all

Browser

all

@narbek-abd narbek-abd added the Awaiting Reproduction Can we reproduce the reported bug? label Oct 11, 2024
@narbek-abd
Copy link
Author

Screencast from 11.10.2024 15:11:57.webm
Removing MG from isSingleImageModality function resolved the issue. But i guess it will broke somewhere else? pls help

@narbek-abd
Copy link
Author

Here is complete code. Worked for all different kind of mammo studies. But i'm not sure

function getDisplaySetsFromSeries(instances) {
  // If the series has no instances, stop here
  if (!instances || !instances.length) {
    throw new Error('No instances were provided');
  }
  const hasMultiSourceImageSequenceInstance = instances.some(
    i => (i.SourceImageSequence || []).length > 1
  );
...
}

const isSingleImageModality = (modality, hasMultiSourceImageSequenceInstance) => {
  return (
    modality === 'CR' ||
    (modality === 'MG' && !hasMultiSourceImageSequenceInstance) ||
    modality === 'DX'
  );
};

@arturojain
Copy link

Had the same issue but this seems to be the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

2 participants