Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3 day SPIKE]: Publishing to NPM needs one time password #3310

Open
rmccar opened this issue Aug 21, 2024 · 0 comments
Open

[3 day SPIKE]: Publishing to NPM needs one time password #3310

rmccar opened this issue Aug 21, 2024 · 0 comments
Labels
Medium priority Spike Requires investigation outside BAU work

Comments

@rmccar
Copy link
Contributor

rmccar commented Aug 21, 2024

Describe the bug

The task to enable 2FA on our NPM account has caused the publish to NPM action to fail when doing the latest release.

We need to investigate and fix this issue so that the release will continue to publish to NPM.

Link to erroring action: https://github.com/ONSdigital/design-system/actions/runs/10386534337/job/28758021461

The action now needs a one time password to publish which would need to be provided at the time of release which would need to mean an extra step to be added to our release process.

Expected behaviour / outcome

Design system version should be released to NPM on GitHub release

List the steps necessary to reproduce the bug

Check NPM for the latest DS release
https://www.npmjs.com/package/@ons/design-system

Additional context

This is one solution: https://github.com/marketplace/actions/npm-otp-publish but there may be better ones so some research will need to be done into other possibilities.

Version 70.0.11 has been published manually

What version of the ONS Design System are you using?

70.0.11

What device(s) are you using?

Desktop

What operating system(s) are you using?

macOS

What browser(s) are you using?

Chrome

@rmccar rmccar added Bug Something isn't working High priority labels Aug 21, 2024
@rmccar rmccar changed the title Publishing to NPM needs one time password [Bug]: Publishing to NPM needs one time password Aug 22, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Spike Requires investigation outside BAU work label Sep 6, 2024
@MagdalenaLarge MagdalenaLarge removed the Bug Something isn't working label Sep 6, 2024
@MagdalenaLarge MagdalenaLarge changed the title [Bug]: Publishing to NPM needs one time password [3 day SPIKE]: Publishing to NPM needs one time password Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium priority Spike Requires investigation outside BAU work
Projects
None yet
Development

No branches or pull requests

3 participants