Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider locking Node and NPM version #727

Open
designorant opened this issue Apr 4, 2022 · 2 comments
Open

Consider locking Node and NPM version #727

designorant opened this issue Apr 4, 2022 · 2 comments

Comments

@designorant
Copy link
Contributor

Node and NPM should ideally be specified in engines property in package.json, and maybe locked via .nvmrc/.node-version files too.

Even with Node v12 as per current DP prerequisites it's clear that different NPM versions were used to resolve packages and create package-lock.json files.

Running make build with [email protected] and [email protected] (that it comes with by default) results with:

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!

which then results in different package-lock.json files:

	modified:   src/legacy/package-lock.json
	modified:   src/package-lock.json

Oddly enough src/package-lock.json is in .gitignore file and yet it's there in the repo. 🤷‍♂️

@designorant
Copy link
Contributor Author

Related: #781

@designorant
Copy link
Contributor Author

The issue above don't seem to be the case anymore but the lock/requirement should really be in place to avoid similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant