Fix secure message return to inbox

[SteveScorfield]

What and why?

Return to the correct inbox was not working correctly for some technical and misc messages when there is recorded survey ID in the secure_message table. The code has been updated so that all technical and misc messages will return to the correct inbox.

How to test?

1. Run unit tests
2. Deploy this PR to your dev env and run the acceptance tests
3. Create a technical message and misc message via Frontstage
4. In rOps got to navigate to the 2 messages and click on them
5. Click the return button and you should be redirected to the correct inbox

Jira

https://jira.ons.gov.uk/browse/RAS-1224

[SteveScorfield]

/deploy scorfs

[ras-rm-pr-bot]

Deploying to dev cluster with following parameters:

• namespace: scorfs

• tag: pr-961

• configBranch: main

• paramKey: ``

• paramValue: ``

[anwilkie]

/deploy wilkia

[ras-rm-pr-bot]

Deploying to dev cluster with following parameters:

• namespace: wilkia

• tag: pr-961

• configBranch: main

• paramKey: ``

• paramValue: ``

[LJBabbage]

This is only part of the story, perhaps it's not explicit in the card, but the original story was to make sure the green message box, with a link to the message (closed, message sent) is present. Unfortunately this still doesn't pass that information for these inboxes

[SteveScorfield]

/deploy scorfs

[ras-rm-pr-bot]

Deploying to dev cluster with following parameters:

• namespace: scorfs

• tag: pr-961

• configBranch: main

• paramKey: ``

• paramValue: ``

[anwilkie]

/deploy wilkia

[ras-rm-pr-bot]

Deploying to dev cluster with following parameters:

• namespace: wilkia

• tag: pr-961

• configBranch: main

• paramKey: ``

• paramValue: ``

[anwilkie]

When I deployed and tested this PR out, I made the following observation:

1. Create a technical message on frontstage.
2. On r-ops, locate the message and assign the thread to a particular survey.
3. Re-assign the thread back to technical/misc.
4. In the message thread view, click on the "return to messages" button at the bottom or the "Messages" hyperlink at the top.

You will be redirected to the inbox for the survey that the thread used to be assigned to, rather than the technical/misc inbox.

[SteveScorfield]

@anwilkie sorry I forgot to update the test steps. You no longer need to make changes in the DB.

[anwilkie]

When I made the aforementioned observation, I didn't make any changes to the database, and I retested it now to ensure that. I'm not sure whether this bug is an issue with the PR itself or if it should be spun off into its own issue.

As things are, I am able to perform the actions described in the "how to test" part of the description without issue; it's just that there is this strange behaviour that is being showcased by message threads that have switched categories. It might be worth discussing this with the rest of the team to get their thoughts on it.

[SteveScorfield]

@anwilkie I see what you mean. I've updated the code to fix the issue after category reassignment.

[SteveScorfield]

/deploy scorfs

[ras-rm-pr-bot]

Deploying to dev cluster with following parameters:

• namespace: scorfs

• tag: pr-961

• configBranch: main

• paramKey: ``

• paramValue: ``

Currently on leave.

[LJBabbage]

A few minor issues, I think we might have to accept that all the tests in this area need work, the mocks are terrible, but good work on the tidy up. The only other query is the pipfile.lock update, it shouldn't really be done here

[arroyoAle]

Looks good and works just a lot of the same comment with a question

[arroyoAle]

Works as expected