Possible race condition in ConsoleReferenceClient

[Stra1ghter]

I don't really understand the locking used in the reference client's UaClient. How can this be sufficient?

ConsoleReferenceClient uses a UAClient class that handles the session. This uses the the KeepAlive event that will be fired by the Session. In Session, the keep alive callback is called on a new thread (Task.Factory.StartNew(...), line 2712). That means both the Session_KeepAlive and the Client_ReconnectComplete run on another thread.

In UaClient.Client_ReconnectComplete we dispose an old session and update our local Session property. This has a lock statement. However the Session property is exposed and used, e.g. in ClientSamples or Program without any synchronization. I.e. they might start read request from a Session that is currently being disposed.

Is there some reason this cannot happen in practice?