Skip to content

Commit 8e0264c

Browse files
authored
Merge pull request #7060 from ORNL-AMO/issue-7059
Issue 7059 - Add logic and defense for new applicationInstanceData
2 parents 83812cd + b52065f commit 8e0264c

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

src/app/core/core.component.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,9 @@ export class CoreComponent implements OnInit {
143143
if (this.electronService.isElectron) {
144144
this.electronUpdateAvailableSub.unsubscribe();
145145
this.releaseDataSub.unsubscribe();
146-
this.applicationInstanceDataSubscription.unsubscribe();
146+
if (this.applicationInstanceDataSubscription) {
147+
this.applicationInstanceDataSubscription.unsubscribe();
148+
}
147149
}
148150
this.assessmentUpdateAvailableSub.unsubscribe();
149151
this.openingTutorialSub.unsubscribe();
@@ -166,7 +168,7 @@ export class CoreComponent implements OnInit {
166168
}
167169
this.setAllDbData();
168170
} else {
169-
await this.coreService.setExistingApplicationInstanceData();
171+
await this.coreService.setApplicationInstanceData();
170172
this.setAllDbData();
171173
}
172174

src/app/core/core.service.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,13 @@ export class CoreService {
7979
this.applicationDataService.applicationInstanceData.next(applicationInstanceData);
8080
}
8181

82-
async setExistingApplicationInstanceData() {
82+
async setApplicationInstanceData() {
8383
let existingApplicationData: Array<ApplicationInstanceData> = await firstValueFrom(this.applicationDataService.getApplicationInstanceData());
84-
this.applicationDataService.applicationInstanceData.next(existingApplicationData[0]);
84+
if (existingApplicationData.length === 0) {
85+
await this.setNewApplicationInstanceData();
86+
} else {
87+
this.applicationDataService.applicationInstanceData.next(existingApplicationData[0]);
88+
}
8589
}
8690

8791
async createDefaultDirectories() {

src/app/dashboard/data-and-backup/data-and-backup.component.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<div class="card-header bold">
3333
Automatic Backup
3434
</div>
35-
<div *ngIf="electronService.isElectron" class="card-body">
35+
<div *ngIf="electronService.isElectron && applicationInstanceData" class="card-body">
3636
<div class="d-flex w-100 alert feature-action">
3737
<div class="d-flex flex-fill">
3838
<label>

0 commit comments

Comments
 (0)