Skip to content

Settings can be accessed by any client player #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xRampey opened this issue Jan 17, 2017 · 5 comments
Closed

Settings can be accessed by any client player #8

0xRampey opened this issue Jan 17, 2017 · 5 comments
Assignees

Comments

@0xRampey
Copy link
Member

Settings can be used to change the current music directory of the server from any client player. This feature should be removed and relocated into a separate function for use only on the server.

@mukkachaitanya
Copy link
Member

mukkachaitanya commented Jan 19, 2017

Commenting all the un-required functionality on the client side player.

@0xRampey
Copy link
Member Author

@mukkachaitanya By un-required do you mean unnecessary utilities? Because the dangerous commented functions can still be used for malicious purposes.

@SebastinSanty
Copy link
Member

@prampey I guess this can be a sub of #9 and closed

@kaivalyar
Copy link
Member

might still want to go through all commented code before releasing to check security ...

@mukkachaitanya
Copy link
Member

In fact there are few other things that modify the details in the database which need to be removed from the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants