[Bug] r.stream.snap deletes table of input map from database

[geografin]

Describe the bug

r.stream.snap command seem to delete a table that is connected to input map.

To reproduce

It should be done with any ready stream network. Use any radius and threshold you want.

1. Execute 'v.in.ogr input=gages.shp output=gages --overwrite' to import any hydrologic stations
2. Check if table gages exists with command db.tables
3. Execute 'r.stream.snap input=gages stream_rast=streams threshold=$threshold radius=$radius output=corr_gages --overwrite'
4. Check db.tables and see that table gages doesn't exist

Expected behavior

r.stream.snap should not touch table "gages". Also as the result corr_gages has no link to database, user should be able to make a link with 'v.db.connect map=corr_gages table=gages' but because of this incorrect behaviour we can't do that.

Screenshots

System description

• Operating System: Linux, on Docker
• GRASS GIS version: 8.4.1dev

Additional context

[aniket2405]

Hey @geografin , I tried to reproduce this on my system:

Operating System: macOS, on GUI
GRASS GIS Version: 8.5.0dev

Test Steps followed:

1. Import test data
   v.in.ogr input=<path_to_grass_repository>/vector/v.in.ogr/testsuite/data/precip_30ynormals_3d.shp output=gages -o --overwrite

2. Create stream raster
   r.mapcalc -s "streams = if(rand(0,1) > 0.9, 1, null())"

3. Run snap
   r.stream.snap input=gages stream_rast=streams threshold=50 radius=100 output=corr_gages --overwrite

4. Check results
   db.tables -p # shows gages table still exists
   v.db.connect -p corr_gages # shows no table connection

My observations:

In macOS:

1. Input gages table is preserved.
2. Output corr_gages has no table connection

Q1. Did I follow the test steps correctly?
Q2. Is this change only due to an environmental change (Linux vs MacOS)?
Q3. Can I reproduce the above error on my macOS?

Thanks for the help!