Skip to content

Commit 0f756f3

Browse files
authored
Merge pull request #2871 from OSInside/omit_kiwi_repart_for_affected_builders
Skip kiwi-repart module in install ISOs
2 parents 29119fb + 5e03e05 commit 0f756f3

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

dracut/modules.d/90kiwi-dump/kiwi-dump-image.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ function get_remote_image_source_files {
513513
#--------------------------------------
514514
setup_debug
515515

516-
initialize
516+
lib_initialize
517517

518518
udev_pending
519519

dracut/modules.d/99kiwi-dump-reboot/kiwi-dump-reboot-system.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
type initialize >/dev/null 2>&1 || . /lib/kiwi-lib.sh
2+
type lib_initialize >/dev/null 2>&1 || . /lib/kiwi-lib.sh
33
type report_and_quit >/dev/null 2>&1 || . /lib/kiwi-dump-image.sh
44
type get_selected_disk >/dev/null 2>&1 || . /lib/kiwi-dump-image.sh
55
type run_dialog >/dev/null 2>&1 || . /lib/kiwi-dialog-lib.sh
@@ -73,7 +73,7 @@ function boot_installed_system {
7373
#======================================
7474
# Reboot into system
7575
#--------------------------------------
76-
initialize
76+
lib_initialize
7777

7878
if getargbool 0 rd.kiwi.ramdisk; then
7979
# For ramdisk deployment a kexec boot is not possible as it

dracut/modules.d/99kiwi-lib/kiwi-lib.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ function bool {
203203
fi
204204
}
205205

206-
function initialize {
206+
function lib_initialize {
207207
# """
208208
# Source profile variables into runtime environment
209209
# The method will exit from the initrd if the profile

kiwi/builder/install.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,7 @@ def _create_pxe_install_kernel_and_initrd(self) -> None:
404404
if self.initrd_system == 'dracut':
405405
self.boot_image_task.include_module('kiwi-dump')
406406
self.boot_image_task.include_module('kiwi-dump-reboot')
407+
self.boot_image_task.omit_module('kiwi-repart')
407408
if self.root_filesystem_is_multipath is False:
408409
self.boot_image_task.omit_module('multipath')
409410
for mod in self.xml_state.get_installmedia_initrd_modules('add'):
@@ -452,6 +453,7 @@ def _create_iso_install_kernel_and_initrd(self) -> None:
452453
if self.initrd_system == 'dracut':
453454
self.boot_image_task.include_module('kiwi-dump')
454455
self.boot_image_task.include_module('kiwi-dump-reboot')
456+
self.boot_image_task.omit_module('kiwi-repart')
455457
if self.root_filesystem_is_multipath is False:
456458
self.boot_image_task.omit_module('multipath')
457459
for mod in self.xml_state.get_installmedia_initrd_modules('add'):

test/unit/builder/install_test.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,8 @@ def side_effect(prefix, path):
256256
self.boot_image_task.include_driver.assert_any_call('driver1')
257257
self.boot_image_task.include_driver.assert_any_call('driver2')
258258
assert self.boot_image_task.omit_module.call_args_list == [
259-
call('multipath'), call('module1'), call('module2')
259+
call('kiwi-repart'), call('multipath'),
260+
call('module1'), call('module2')
260261
]
261262
self.boot_image_task.set_static_modules.assert_called_once_with(
262263
['module1', 'module2']
@@ -450,7 +451,7 @@ def test_create_install_pxe_archive(
450451
self.boot_image_task.include_driver.assert_any_call('driver1')
451452
self.boot_image_task.include_driver.assert_any_call('driver2')
452453
assert self.boot_image_task.omit_module.call_args_list == [
453-
call('multipath'), call('module1'), call('module2')
454+
call('kiwi-repart'), call('multipath'), call('module1'), call('module2')
454455
]
455456
self.boot_image_task.set_static_modules.assert_called_once_with(
456457
['module1', 'module2']

0 commit comments

Comments
 (0)