Merge pull request #2650 from IsaacJT/increase-dd-block-size

storage: clone_device: increase dd block size

Author: IsaacJT

kiwi/storage/clone_device.py

@@ -56,7 +56,8 @@ def clone(self, target_devices: List[DeviceProvider]):
                 [
                     'dd',
                     'if={0}'.format(self.source_provider.get_device()),
-                    'of={0}'.format(target_device.get_device())
+                    'of={0}'.format(target_device.get_device()),
+                    'bs=1M'
                 ]
             )
             clone_id = BlockID(target_device.get_device())

test/unit/storage/clone_device_test.py

@@ -39,7 +39,7 @@ def test_clone_filesystem(
         self.clone_device.clone([self.target_device])
 
         mock_Command_run.assert_called_once_with(
-            ['dd', 'if=/dev/source-device', 'of=/dev/target-device']
+            ['dd', 'if=/dev/source-device', 'of=/dev/target-device', 'bs=1M']
         )
         mock_FileSystem_new.assert_called_once_with(
             'ext3', self.target_device
@@ -57,7 +57,10 @@ def test_clone_lvm(self, mock_BlockID, mock_Command_run):
 
         assert mock_Command_run.call_args_list == [
             call(
-                ['dd', 'if=/dev/source-device', 'of=/dev/target-device']
+                [
+                    'dd', 'if=/dev/source-device', 'of=/dev/target-device',
+                    'bs=1M'
+                ]
             ),
             call(
                 ['vgimportclone', '/dev/target-device']
@@ -76,7 +79,10 @@ def test_clone_luks(self, mock_uuid4, mock_BlockID, mock_Command_run):
 
         assert mock_Command_run.call_args_list == [
             call(
-                ['dd', 'if=/dev/source-device', 'of=/dev/target-device']
+                [
+                    'dd', 'if=/dev/source-device', 'of=/dev/target-device',
+                    'bs=1M'
+                ]
             ),
             call(
                 [
@@ -114,7 +120,10 @@ def test_clone_raid(
             .return_value.set_uuid.assert_called_once_with()
         assert mock_Command_run.call_args_list == [
             call(
-                ['dd', 'if=/dev/source-device', 'of=/dev/target-device']
+                [
+                    'dd', 'if=/dev/source-device', 'of=/dev/target-device',
+                    'bs=1M'
+                ]
             ),
             call(
                 ['mdadm', '--stop', '/dev/md0']