Skip to content

"Unchanged" should hidden by default, or rel should be separated from way #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kovoschiz opened this issue Apr 8, 2025 · 3 comments

Comments

@Kovoschiz
Copy link

Kovoschiz commented Apr 8, 2025

The map is cluttered by routes when there are changes on the roads, when this is considered an indirect change from their members. Users can toggle it if they want to. Or better, indirect change on way from moved node should be a different option from relation members. Change in line geometry is more significant.
The older design of showing only the object bbox by default also works. Clicking on it shows the entire rel with its members.

@gram2222
Copy link

These unchanged object as the member of a relation should not loaded to reduce burden of memory if a relation itself is not changed, as older design

@jake-low
Copy link
Contributor

Or better, indirect change on way from moved node should be a different option from relation members. Change in line geometry is more significant.

Maybe I'm misunderstanding your request, but I think this is already the case? For example, in this changeset, several roads are unchanged, such as the circular roundabout and the road extending east from it. But they are shown in gray, not purple, because their geometries changed (even though the ways themselves were untouched), and they are toggled on and off as part of the "Modified" group, not the "Unchanged" group. The "Unchanged" group contains only parent relations of modified elements, and members of modified relations.

These unchanged object as the member of a relation should not loaded to reduce burden of memory if a relation itself is not changed, as older design

The old design loaded these elements too, but they were invisible until you clicked on a relation.

For example, here's a changeset which changed tags on some relations in the old renderer vs the new renderer. Clicking on a relation box in the old implementation will reveal its members (with no additional network request).

If there are specific changesets that you're seeing performance problems when loading, please post them here and I can investigate them.

@Kovoschiz
Copy link
Author

The effect in https://osmcha.org/changesets/164672680 isn't obvious, although you could technically see the restriction=no_u_turn appearing. I'm referring to all route=bus being loaded when the member has an "internal" change. https://osmcha.org/changesets/164791490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants