-
Notifications
You must be signed in to change notification settings - Fork 40
"Unchanged" should hidden by default, or rel
should be separated from way
#775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These unchanged object as the member of a relation should not loaded to reduce burden of memory if a relation itself is not changed, as older design |
Maybe I'm misunderstanding your request, but I think this is already the case? For example, in this changeset, several roads are unchanged, such as the circular roundabout and the road extending east from it. But they are shown in gray, not purple, because their geometries changed (even though the ways themselves were untouched), and they are toggled on and off as part of the "Modified" group, not the "Unchanged" group. The "Unchanged" group contains only parent relations of modified elements, and members of modified relations.
The old design loaded these elements too, but they were invisible until you clicked on a relation. For example, here's a changeset which changed tags on some relations in the old renderer vs the new renderer. Clicking on a relation box in the old implementation will reveal its members (with no additional network request). If there are specific changesets that you're seeing performance problems when loading, please post them here and I can investigate them. |
The effect in https://osmcha.org/changesets/164672680 isn't obvious, although you could technically see the |
The map is cluttered by routes when there are changes on the roads, when this is considered an indirect change from their members. Users can toggle it if they want to. Or better, indirect change on
way
from movednode
should be a different option fromrelation
members. Change in line geometry is more significant.The older design of showing only the object bbox by default also works. Clicking on it shows the entire
rel
with its members.The text was updated successfully, but these errors were encountered: