Adding short version of OSeMOSYS PULP and udpates to the long code #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willu47
requested changes
Jun 12, 2023
| # FUNCTIONS | ||
| # ---------------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| def createParameter(_df, _name): |
There was a problem hiding this comment.
These utility functions are duplicated over the various versions of the code. I suggest moving these into a utility module e.g. utils.py and then importing them.
There was a problem hiding this comment.
Should this be part of the pull request? If not, please remove. If this is a to-do list, consider adding these as individual issues on Github.
There was a problem hiding this comment.
Should this be part of the pull request as it looks like a result file?
|
|
||
| OSeMOSYS-PuLP-HP | ||
|
|
||
| This is the high performance (HP) version of OSeMOSYS-PuLP |
| @@ -0,0 +1,1013 @@ | |||
| # !/usr/bin/env python3 | |||
| # -*- coding: utf-8 -*- | |||
| # Author: Dennis Dreier, Copyright 2020 | |||
|
|
||
| Please cite this software by using the following reference of the original scientific article: | ||
|
|
||
| Dennis Dreier, Mark Howells, OSeMOSYS-PuLP: A Stochastic Modeling Framework for Long-Term Energy Systems Modeling. |
There was a problem hiding this comment.
Add citation as a citation.cff file in the repository.
|
|
||
| """ | ||
|
|
||
| path_to_cplex = r'C:/Program Files/IBM/ILOG/CPLEX_Studio1262/cplex/bin/x64_win64/cplex.exe' |
There was a problem hiding this comment.
This should be in a user-defined config file somewhere, not hard-coded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.