Automated Build for All Formats

[ike]

We should have an automated build of all formats, using the new Docker build system. Can we use GitHub actions for this?

c/f: #1294 (comment)

[elarlang]

Just in case mention, that it should work (and tested) with all translations.

[tghosth]

hey @ike,

I am working on a very basic Github action for this.

I have created PR #1679 but it does take quite a long time to run because of the time taken to build the container image.

[ike]

Hey @tghosth! That's what I found too -- I ended up pushing the image to docker hub and adjusting the run commands so it pulls before running. The action only takes ~2 mins with that change.

I am running into quite a few little problems, mostly related to the 4.0 docx files changing every time their built due to an internal time stamp.

I really like how you split things into multiple actions for 5.0/4.0 -- This solves quite a few odd behaviors I was experiencing.

I think we should create an ASVS repo on docker hub and publish the image there.

Feel free to borrow from any of this stuff in my branch: https://github.com/ike/asvs/tree/github-actions

[tghosth]

at this point I am less worried about the outputs being committed back into the repository itself. The current action just creates them as artefacts which can be downloaded from the repo:

e.g.
https://github.com/OWASP/ASVS/actions/runs/5475362014

[ike]

Okay, I created PR #1680 that uses GHCR for the image repository. We will need to create a package and associated secrets for the ASVS repo before merging.

[tghosth]

ok so would it make sense to create one action that creates and pushes the container and another action that generates the outputs? At that point, I don't see how the container is being created/published.

[ike]

@tghosth as it stands, the image is created and pushed manually. The action that builds the image could also push it to the repository. We would need to set up the correct access secrets for that.

[tghosth]

so can you update the PR to split it so one action creates and pushes the container and another action runs the output generation?

[ike]

@tghosth yep can do!

[ike]

Fixed with #1680

[tghosth]

Hi @ike, Can you check the logs, it looks like the image publish didn't succeed, maybe because it is going into ike instead of OWASP? Can you PR suggested changes to make it work?