Merge pull request 'clean: remove the unnecessary code which was supposed to be removed in previous PR' (#252) from sync-apps/remove-logic-to-update-argocd-at-last into main

ashish1099 · ashish1099 · commit 1d513a00e172 · 2025-07-28T12:05:32.000+02:00
Reviewed-on: https://gitea.obmondo.com/EnableIT/kubeaid-bootstrap-script/pulls/252
diff --git a/pkg/utils/kubernetes/argo.go b/pkg/utils/kubernetes/argo.go
@@ -235,17 +235,9 @@ func SyncAllArgoCDApps(ctx context.Context) {
 		assert.AssertErrNil(ctx, err, "Failed listing ArgoCD apps")
 
 		for _, item := range response.Items {
-			// Skip syncing argocd ArgoCD app while syncing other ArgoCD apps.
-			if item.Name == constants.ArgoCDAppArgoCD {
-				continue
-			}
-
 			SyncArgoCDApp(ctx, item.Name, []*argoCDV1Aplha1.SyncOperationResource{})
 		}
 	}
-
-	// Lastly, sync the argocd ArgoCD app.
-	SyncArgoCDApp(ctx, constants.ArgoCDAppArgoCD, []*argoCDV1Aplha1.SyncOperationResource{})
 }
 
 // Syncs the ArgoCD App (if not synced already).

Original file line number	Diff line number	Diff line change
`@@ -235,17 +235,9 @@ func SyncAllArgoCDApps(ctx context.Context) {`
`235`	`235`	`assert.AssertErrNil(ctx, err, "Failed listing ArgoCD apps")`
`236`	`236`
`237`	`237`	`for _, item := range response.Items {`
`238`		`- // Skip syncing argocd ArgoCD app while syncing other ArgoCD apps.`
`239`		`- if item.Name == constants.ArgoCDAppArgoCD {`
`240`		`- continue`
`241`		`- }`
`242`		`-`
`243`	`238`	`SyncArgoCDApp(ctx, item.Name, []*argoCDV1Aplha1.SyncOperationResource{})`
`244`	`239`	`}`
`245`	`240`	`}`
`246`		`-`
`247`		`- // Lastly, sync the argocd ArgoCD app.`
`248`		`- SyncArgoCDApp(ctx, constants.ArgoCDAppArgoCD, []*argoCDV1Aplha1.SyncOperationResource{})`
`249`	`241`	`}`
`250`	`242`
`251`	`243`	`// Syncs the ArgoCD App (if not synced already).`