1.1.3

Author: Arthur LORENT

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.1.3](https://github.com/Okipa/laravel-request-sanitizer/releases/tag/1.1.3)
+2019-09-13
+- Fixed wrong sanitizing for doubles.
+
 ## [1.1.2](https://github.com/Okipa/laravel-request-sanitizer/releases/tag/1.1.2)
 2019-09-12
 - Fixed missing `string` return type in `sanitize()` and `sanitizeFromType()` methods PHPDOC.

src/DataSanitizer.php

@@ -51,7 +51,7 @@ protected function sanitizeFromType($entry, bool $jsonDecodeAssoc)
         } elseif ($this->isTrue($entry)) {
             return true;
         } elseif (is_numeric($entry)) {
-            if ((int) $entry !== $entry) {
+            if (((int) $entry) - ((double) $entry) !== 0.0) {
                 return doubleval($entry);
             } else {
                 return intval($entry);

tests/DataSanitizerTest.php

@@ -44,10 +44,24 @@ public function testSanitizeReturnsNullForEmptyString()
         $this->assertNull($this->DataSanitizer->sanitize(''));
     }
 
-    public function testSanitizeTransformsStringToNumber()
+    public function testSanitizeInteger()
     {
-        $this->assertEquals(0, $this->DataSanitizer->sanitize('0'));
-        $this->assertEquals(2.07, $this->DataSanitizer->sanitize('2.07'));
+        $this->assertEquals(3, $this->DataSanitizer->sanitize('3'));
+    }
+
+    public function testSanitizeNegativeInteger()
+    {
+        $this->assertEquals(-3, $this->DataSanitizer->sanitize('-3'));
+    }
+
+    public function testSanitizeFloat()
+    {
+        $this->assertEquals(3.14, $this->DataSanitizer->sanitize('3.14'));
+    }
+
+    public function testSanitizeNegativeFloat()
+    {
+        $this->assertEquals(-3.14, $this->DataSanitizer->sanitize('-3.14'));
     }
 
     public function testSanitizeAcceptsDefaultParameter()