Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Newtonsoft.Json #1001

Closed
o-l-a-v opened this issue Aug 8, 2023 · 1 comment
Closed

Update dependency Newtonsoft.Json #1001

o-l-a-v opened this issue Aug 8, 2023 · 1 comment

Comments

@o-l-a-v
Copy link

o-l-a-v commented Aug 8, 2023

Please get dependency Newtonsoft.Json up to date, both for the security fix found in >= 13.0.1 ( GHSA-5crp-9r3c-p9vr ), general bugfixes, and for (hopefully) getting the Azure powershell modules to work with the Visual Studio Code PowerShell extension + Windows PowerShell 5.1, where OmniSharp/csharp-language-server-protocol is a component in PowerShellEditorServices.

Seems the renovate bot made a PR to update Newtonsoft.Json, but some check failed (?) and it hasn't been merged:

Related issues:


Edit: I see now that the security fix is already mitigated by setting max depth for JSON serialization. Still, would be nice to get Netwonsoft.Json up to date for the two other mentioned reasons.

@JoeRobich
Copy link
Member

Closing as #839 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants