DT Overlay Functionality not available after reboot

[greenbreakfast]

What package does this bug affect?

onion-dt-overlay-sw-spi and onion-dt-overlay-w1-gpio in the openwrt-23.05 branch

And most likely in openwrt-22.03 branch as well
EDIT: tested on openwrt-22.03 based firmware and did not find the same issue. See comment below for details.

Describe the bug

The functionality added by installing Device Tree Overlay packages is only available until the device is powered off or rebooted.
Once the device reboots, the DT overlay seems to still be in place, but the functionality is not available. That is the additional software SPI bus and the one-wire master are not available.

To Reproduce

Used the OnionIoT/omega2-fw-tester to test this quickly

Steps to reproduce the behavior:

1. Flash the latest onion_omega2p-23.05.3-20240610.bin firmware to the device
2. Setup wifi or otherwise connect the device to the internet
3. On connected computer, run pytest -v test_device.py --json-config test_cases/400_opkg_update.json test_cases/600_dt_overlay.json, observe all tests pass

4. Reboot the Omega2 device
5. On connected computer, run pytest -v test_device.py --json-config test_cases/600_dt_overlay.json, observe the tests that check functionality fail:

Expected behavior

Expecting Software SPI and One-Wire Master to be available and work properly after a reboot or power off

Screenshots or Console output

After initial installation of the dt overlay packages (step 3 above), tested manually on command line and both SW SPI and One-Wire worked. Could even read temperature data from a connected sensor:

After rebooting the device (step 4 above), tested manually on command line again. No SW SPI device available, not one-wire master device available:

Version Info (please complete the following information):

• Firmware version: 23.05.3-20240610
• Package name: onion-dt-overlay-sw-spi and onion-dt-overlay-w1-gpio
• Package Version: 1.0-5
• Repo branch (if applicable) openwrt-23.05 branch

[greenbreakfast]

Tested on 22.03.5-20240517 firmware and did not have the same issue. So this issue is only present on the 23.05.3 firmware!

After fresh fw install:

After reboot:

[YevheniiOnishchenkoLemberg]

Fixed in PR "Fix dt-overlay patch #35". Results below are for initial boot and after pressing the reset button. The failed "boot" test case indicated actual reset was happening:

[greenbreakfast]

Confirming this issue is resolved in the 23.05.3-20240724 release.

Successfully tested on 23.05.3-20240724 firmware from 23.05.3-20240724 release

Followed test procedure from original post
After fresh fw install, dt-overlay installation and functionality checks pass:

After reboot, dt-overlay functionality checks pass:

Also tested one-wire device after reboot, works as expected. Just noticed a few ghost one-wire slave devices, but that can be investigated at a later date:
EDIT: no ghost devices are detected if one-wire master pin is not left floating