fix: deprecate transfer in title escrow (#58)

Author: superical

contracts/TitleEscrowCloneable.sol

@@ -102,11 +102,7 @@ contract TitleEscrowCloneable is Context, Initializable, ITitleEscrow, HasHolder
     tokenRegistry.safeTransferFrom(address(this), address(newOwner), _tokenId);
   }
 
-  function transferTo(address newOwner) public virtual override isHoldingToken onlyHolder allowTransferOwner(newOwner) {
-    revert("Transfer disabled");
-  }
-
-  function surrender() external isHoldingToken onlyBeneficiary onlyHolder {
+  function surrender() external override isHoldingToken onlyBeneficiary onlyHolder {
     _transferTo(address(tokenRegistry));
   }
 

contracts/interfaces/ITitleEscrow.sol

@@ -44,9 +44,8 @@ interface ITitleEscrow is IHasHolder, IHasBeneficiary, IERC165, IERC721Receiver
   /// @param newHolder The address of the new holder
   function changeHolder(address newHolder) external;
 
-  /// @notice Handle the token transfer by the holder after beneficiary's endorsement
-  /// @param newBeneficiary The address of the new holder
-  function transferTo(address newBeneficiary) external;
+  /// @notice Surrender token back to registry
+  function surrender() external;
 
   /// @notice Public getter to access the approved owner if any
   function approvedOwner() external returns (address);

contracts/mocks/TitleEscrowCloneableMock.sol

@@ -4,7 +4,7 @@ pragma solidity ^0.8.0;
 import "../TitleEscrowCloneable.sol";
 
 contract TitleEscrowCloneableMock is TitleEscrowCloneable  {
-  function transferTo(address newOwner) public override isHoldingToken onlyHolder allowTransferOwner(newOwner) {
+  function transferTo(address newOwner) public isHoldingToken onlyHolder allowTransferOwner(newOwner) {
     _transferTo(newOwner);
   }
 }

test/TitleEscrowCloneable.js

@@ -72,7 +72,7 @@ describe("TitleEscrowCloneable", async () => {
 
   it("should have the correct ERC165 interface support", async () => {
     const escrowInstance = await makeTitleEscrow(beneficiary1.address, beneficiary1.address);
-    const ITitleEscrowInterfaceId = "0x015509a1";
+    const ITitleEscrowInterfaceId = "0x1676e9e0";
     const interfaceSupported = await escrowInstance.supportsInterface(ITitleEscrowInterfaceId);
     expect(interfaceSupported).to.be.equal(true, `Expected selector: ${ITitleEscrowInterfaceId}`);
   });