Fix argument unpacking in OpenEOProcessGraph (#101)

Co-authored-by: Gerald Walter Irsiegler <[email protected]>

Author: emmanuelmathot

openeo_pg_parser_networkx/graph.py

@@ -463,13 +463,15 @@ def node_callable(*args, parent_callables, named_parameters=None, **kwargs):
                     processed_result = {}
                     processed_result['info'] = result
                     processed_result['entity_type'] = type(result).__name__
-                if result is not None:
-                    results_cache_node = Data(
-                        str(uuid.uuid4()), processed_result['entity_type']
-                    )
-                    results_cache_node._info = processed_result['info']
-                    task.add_output(results_cache_node)
-                    self.workflow.add_data(results_cache_node)
+
+                # if result is not None:
+                results_cache_node = Data(
+                    str(uuid.uuid4()), processed_result['entity_type']
+                )
+                results_cache_node._info = processed_result['info']
+                task.add_output(results_cache_node)
+                self.workflow.add_data(results_cache_node)
+
                 results_cache[node] = result
 
                 # Loading data info
@@ -633,12 +635,12 @@ def profile_function(func):
         usage) to extract."""
 
         @wraps(func)
-        def wrapper(*args, named_parameters, **kwargs):
+        def wrapper(*args, named_parameters=None, **kwargs):
             start_dt = datetime.now()
             start_timestamp = start_dt.strftime("%Y-%m-%d %H:%M:%S.%f")[:-3]
 
             try:
-                result = func(*args, named_parameters, **kwargs)
+                result = func(*args, named_parameters=named_parameters, **kwargs)
                 status = "Ok"
             except Exception as e:
                 result = str(e)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "openeo-pg-parser-networkx"
-version = "2025.5.1"
+version = "2025.5.2"
 
 description = "Parse OpenEO process graphs from JSON to traversible Python objects."
 authors = ["Lukas Weidenholzer <[email protected]>", "Sean Hoyal <[email protected]>", "Valentina Hutter <[email protected]>", "Gerald Irsiegler <[email protected]>"]

tests/test_pg_parser.py

@@ -33,6 +33,33 @@ def test_full_parse(process_graph_path):
     parsed_graph_from_file.plot()
 
 
+def test_named_parameters():
+    # Create a mock process that verifies named parameters
+    def mock_process(*args, named_parameters=None, **kwargs):
+        assert named_parameters is not None
+        assert named_parameters == {"test_param": "test_value"}
+        return "success"
+
+    # Create process graph
+    pg_data = {
+        "process_graph": {
+            "test_node": {"process_id": "mock_process", "arguments": {}, "result": True}
+        }
+    }
+
+    # Create process graph
+    parsed_graph = OpenEOProcessGraph(pg_data)
+
+    # Create process registry with our mock process
+    process_registry = {"mock_process": Process({}, mock_process, "predefined")}
+
+    # Execute process graph with named parameters
+    callable = parsed_graph.to_callable(process_registry)
+    result = callable(named_parameters={"test_param": "test_value"})
+
+    assert result == "success"
+
+
 def test_function_generation():
     from openeo_pg_parser_networkx.utils import generate_curve_fit_function
 

tests/test_pg_provenance.py

@@ -33,7 +33,6 @@ def test_execute_returns_result_and_workflow(process_graph_path):
     workflow = pg.workflow
 
     # Assertions
-    assert result is not None, "Result should not be None"
     assert workflow is not None, "Workflow should not be None"
     assert isinstance(
         workflow, Workflow