Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add working leaderboard #1

Open
chrisinajar opened this issue Jan 24, 2018 · 10 comments
Open

Add working leaderboard #1

chrisinajar opened this issue Jan 24, 2018 · 10 comments

Comments

@chrisinajar
Copy link
Member

Use this endpoint: http://chrisinajar.com:6969/top
Those are steam32 ID's

@IBurn36360
Copy link

Same as #2, is this being worked on?

@IBurn36360
Copy link

I tossed this up in 10 minutes. If you give me an idea of what you want it to look like and what functionality you want, I can very easily code it. These changes are being made in a way that isn't blocking to the responsiveness fixes.

@vatsalyagoel
Copy link
Collaborator

vatsalyagoel commented Jan 26, 2018

This looks good to me. follows similar strategy to Dota2 Official leaderboards

@chrisinajar
Copy link
Member Author

chrisinajar commented Jan 26, 2018

Pop it in a PR, we can always enhance it more later. Getting something simple up is a billion times better than having nothing. Since I've added names to the API it should be super trivial, that was the only hard part before.

@IBurn36360
Copy link

I'm getting the Mongo caching layer in before I get the PR up. I'll do a bit of responsive testing to ensure the table doesn't overflow screens as the client width shrinks. Worst case, I'll make it scroll. Do we plan on making this just a static asset, or is there any consideration to making it searchable?

@vatsalyagoel
Copy link
Collaborator

Make it a static asset

@IBurn36360
Copy link

It needs to update as the leaderboard itself does. As an additional note, though web dev is my day job, this is my first dive into Angular, so I'm having to do a lot of reading in order to get things in place.

@vatsalyagoel
Copy link
Collaborator

Hey @IBurn36360 I did a temp version of the leaderboard. Is there anything in particular you want to add to that?

@IBurn36360
Copy link

Yours still calls to Chris' server from the client side, but it works if we need to get the leaderboard up. I'd just be ready to pull it in case someone decides to be a troll and hammer Chris' server through the site.

@vatsalyagoel
Copy link
Collaborator

yeah I'm not exposing chris's server anymore and I have rate limited my own url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants