-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add working leaderboard #1
Comments
Same as #2, is this being worked on? |
This looks good to me. follows similar strategy to Dota2 Official leaderboards |
Pop it in a PR, we can always enhance it more later. Getting something simple up is a billion times better than having nothing. Since I've added names to the API it should be super trivial, that was the only hard part before. |
I'm getting the Mongo caching layer in before I get the PR up. I'll do a bit of responsive testing to ensure the table doesn't overflow screens as the client width shrinks. Worst case, I'll make it scroll. Do we plan on making this just a static asset, or is there any consideration to making it searchable? |
Make it a static asset |
It needs to update as the leaderboard itself does. As an additional note, though web dev is my day job, this is my first dive into Angular, so I'm having to do a lot of reading in order to get things in place. |
Hey @IBurn36360 I did a temp version of the leaderboard. Is there anything in particular you want to add to that? |
Yours still calls to Chris' server from the client side, but it works if we need to get the leaderboard up. I'd just be ready to pull it in case someone decides to be a troll and hammer Chris' server through the site. |
yeah I'm not exposing chris's server anymore and I have rate limited my own url |
Use this endpoint: http://chrisinajar.com:6969/top
Those are steam32 ID's
The text was updated successfully, but these errors were encountered: