-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededquestionFurther information is requestedFurther information is requested
Description
Had two runs over the past few weeks fail with the traceback:
Traceback (most recent call last):
File "/home/runner/work/MarketWatch/MarketWatch/post_generator.py", line 297, in <module>
generate_post(os.environ["GUARDIAN_API_KEY"], date)
File "/home/runner/work/MarketWatch/MarketWatch/post_generator.py", line 265, in generate_post
article = get_random_article(guardian_api_key, date)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/MarketWatch/MarketWatch/post_generator.py", line 196, in get_random_article
"tags": [article["pillarName"]],
~~~~~~~^^^^^^^^^^^^^^
KeyError: 'pillarName'
The obvious solution would be to replace
Line 196 in 9ff71af
"tags": [article["pillarName"]], |
with:
"tags" : [article["pillarName"]] if "pillarName" in article else [],
but the concern is that if this field is ever legitimately renamed, then no articles will have tags from then on.
I suggest looking into which articles don't have pillarNames—it's quite possible that they're not something I want to be pulling in the first place (in which case get_random_article
should be rerun).
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededquestionFurther information is requestedFurther information is requested