-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opendrr psra canada #211
Conversation
Added PSRA Canada Agg Loss layers to pygeoapi
Added parameter to config to select version desired. Removed version from collection name.
@drotheram will this close or address #193? |
Yes it should @anthonyfok do you know the command to auto-fix these linting errors? |
@drotheram I patched the OPENAPI linter errors. Most of the errors had to do with a 'long' type for a variable. @wkhchow Did we change a variable type to 'long' recently? This type is not supported in OPENAPI so I had to manually change it to 'number'. |
That's odd. Only recent var change was the varchar to float. |
requirements.txt
Outdated
@@ -1,10 +1,10 @@ | |||
elasticsearch==7.16.1 | |||
elasticsearch>=7.16.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this could be a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like replacing >=
with the "compatible release operator" ~=
would do the trick. For example, as of today:
pip3 install -U 'elasticsearch~=7.16.1'
would install elasticsearch-7.16.3 for me, whereaspip3 install -U 'elasticsearch>=7.16.1'
would install/upgrade to elasticsearch-8.2.3- Running
pip3 install -U 'elasticsearch~=7.16.1'
again would downgrade to elasticsearch-7.16.3
And, finally, pip3 install -U 'elasticsearch~=7.16'
would get us elasticsearch-7.17.4
References:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the exception of requirements.txt
ES version
No description provided.