GitHub Actions & test fixes, Python versions, myst-parser versions

Author: jarofgreen

.github/workflows/lint.yml

@@ -5,15 +5,11 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Setup python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
-        python-version: 3.8
+        python-version: 3.12
         architecture: x64
-    - uses: actions/cache@v1
-      with:
-        path: ~/.cache/pip
-        key: ${{ runner.os }}-pip-${{ hashFiles('**/setup.py') }}
     - run: pip install -e .[test]
     - run: flake8 .

.github/workflows/test.yml

@@ -7,28 +7,22 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        python-version: [  '3.8', '3.9', '3.10', '3.11']
+        python-version: [  '3.9', '3.10', '3.11', '3.12' ]
         # Removed testing of myst-parser-version<0.18.0
-        myst-parser-version: [ '>=0.18.0,<0.19', '>=0.19.0,<1.0', '>=1.0.0,<2', '>=2.0.0,<3', '>=3.0.0,<4']
+        myst-parser-version: [ '>=0.18.0,<0.19', '>=0.19.0,<1.0', '>=1.0.0,<2', '>=2.0.0,<3', '>=3.0.0,<4', '>=4,<5' ]
         jsonref-version: [">1"]
         include:
           # jsonref 1.0 has a backwards incompatible change - make sure we test just once with an older version of jsonref
           - python-version: '3.11'
             jsonref-version: "==0.3"
             myst-parser-version: '>=3.0.0,<4'
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Setup python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
         architecture: x64
-    - uses: actions/cache@v1
-      with:
-        path: ~/.cache/pip
-        key: ${{ runner.os }}-pip-${{ hashFiles('**/setup.py') }}-${{ matrix.python-version }}
-        restore-keys: |
-          ${{ runner.os }}-pip-
     - run: pip install -e .[test]
     - run: pip install 'jsonref${{ matrix.jsonref-version }}'
     - run: pip install "myst-parser${{ matrix.myst-parser-version }}"

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Changed
+
+- Dropped support for Python 3.8 and lower, as these are end of life
+
 ## [0.7.1] - 2024-11-25
 
 ### Fixed

setup.py

@@ -32,7 +32,7 @@
     platforms='any',
     packages=find_packages(),
     include_package_data=True,
-    python_requires='>=3.8',
+    python_requires='>=3.9',
     install_requires=[
         'docutils',
         'jsonref',

tests/test_directive.py

@@ -7,9 +7,15 @@
 
 
 def normalize(string):
-    # Remove all newlines and indentation to normalise, but then add some
+    # Remove all newlines and indentation to normalise
+    string = re.sub(r"\n *", "", string)
+    # Remove <div class="clearer"></div> - some versions add this in and some don't,
+    # so we need to normalise to one to make our test work with all versions
+    string = string.replace('<div class="clearer"></div>', "")
+    # but then add some
     # newlines back in to make pytest comparison output easier to read.
-    return re.sub(r'\n *', '', string).replace(">", ">\n")
+    string = string.replace(">", ">\n")
+    return string
 
 
 def assert_build(app, status, warning, basename, buildername='html', messages=None):