hswidget/PaletteSelectWidget: refactor #312
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravestench
reviewed
Jun 7, 2021
gucio321
changed the title
gucio321
force-pushed
the
issue-299
branch
2 times, most recently
from
c5c280d
to
a581bd1
Compare
|
please rebase off of upstream master |
…t with `X` button
|
@gravestench done |
gravestench
suggested changes
Jul 6, 2021
|
okey, after a small linvestigation, I found that the bug is caused by build method improvement: if e.selectPalette {
// build palette select
}
dt1Viewer := dt1widget.Create(e.state, e.palette, e.textu
e.Layout(g.Layout{
dt1Viewer,
})so building widget also happens if selectPalette is active |
|
I think that your proposed changes, which are related to selecting a palette, would be more coherent inside of this refactor. |
|
yeah, that's what I mean exactly, I'll work on it before this PR will be ready |
when palette was changed, the widget didn't detected it. now palette is saved in widgetState and widget detects if palette was changed.
for more details, see 342fb35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a refactor of palette select (for dc6, dcc and d61 editors) related code.
CHANGELOG:
rgbafield from dc6 widget stateCreate. I suppose, it'd be better to add a separated method for setting this argument.