Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test everything that can be tested #130

Open
IAlibay opened this issue Apr 21, 2024 · 1 comment
Open

Test everything that can be tested #130

IAlibay opened this issue Apr 21, 2024 · 1 comment
Assignees
@mikemhenry

Comments

@IAlibay
Copy link
Member

IAlibay commented Apr 21, 2024

The majority of our notebooks do not get tested, see: https://github.com/OpenFreeEnergy/ExampleNotebooks/blob/main/.github/workflows/CI.yml#L65

Making sure that our notebooks are kept up to date is really important (it's major feedback we got from our partners last year). We should try to test everything that can be tested.
@IAlibay
Copy link
Member Author

IAlibay commented Apr 21, 2024

@mikemhenry I'm going to make you the shepherd for this if it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemhenry mikemhenry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemhenry @IAlibay