-
Notifications
You must be signed in to change notification settings - Fork 10
ExplicitSolvationComponent #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@IAlibay what is the urgency of this? I'd like to triage it into an upcoming milestone, so any sense of when you'd like to see this enhancement would help! |
Here are some more thoughts based on the last GUFE meeting on the design of these components. Based on the need for an ExplicitRepeatedComponent:
From this we can then create an From the need to be loaded from a pdb it might make sense if it inherits from the protein component are there any draw backs to this and are there any glaring issues with this design? One thing I would point out is that from a user perspective this is a bit more awkward, simulating an explicitly solvated protein-ligand complex now requires you to extract the protein, solvent, and small molecule into different files before loading them into the components and creating the system. Does this seem reasonable @atravitz, @IAlibay @hannahbaumann ? |
From an initial read, I don't think this would work. Could you maybe present this at a meeting for further discussion please? |
A simpler option for the solvated membrane component case is to just sneak this all into a |
Another related issue that might help with design work OpenFreeEnergy/openfe#911 |
We are currently gathering user stories from folks on this to help guide the design of the implementation. We want to get these user stories as part of our v1.3 cycle, even if the implementation lands in a future release. |
We need a component that explicitly defines the solvent / environment of a system.
Examples use cases:
Potential user facing behaviour:
The text was updated successfully, but these errors were encountered: