Skip to content

Commit dfc4d4e

Browse files
committed
show Qt lib version, not Qt compile version; min CMake ver. 3.10 -> 3.12
Signed-off-by: Martin <[email protected]>
1 parent 68439b7 commit dfc4d4e

File tree

4 files changed

+11
-19
lines changed

4 files changed

+11
-19
lines changed

CHANGELOG

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
2025-09-02 (c73f7de): reorder logical functions
1+
2025-09-02 (68439b7): reorder logical functions; update translations
22
2025-06-22 (e15ed3a): Added XOR function to the MathChannel module.
33
2025-09-01 (ef3f244): Back to GO, disable MinGW build until a volunteer fixes it for Qt6
44
2025-09-01 (8b3dd27): mingw-w64-x86_64-clang-libs: for lupdate

CMakeLists.txt

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
1+
cmake_minimum_required(VERSION 3.12 FATAL_ERROR)
22
project(OpenHantek)
33

44
find_package(Git)
@@ -76,19 +76,11 @@ if(CMAKE_COMPILER_IS_GNUCXX)
7676
endif()
7777

7878
# enable extra feature(s)
79-
if( ${CMAKE_VERSION} VERSION_LESS "3.12.0" ) # deprecated, but still used in older Ubuntu releases
80-
# Enable C++ standard library hardening -> cheap range checks for C++ arrays, vectors, and strings.
81-
add_definitions( -D_GLIBCXX_ASSERTIONS )
82-
add_definitions( -D_USE_MATH_DEFINES )
83-
if ( DEFINED VERSION )
84-
add_definitions( -DVERSION="${VERSION}" )
85-
endif()
86-
else() # 'add_compile_definitions()' was introduced with CMake 3.12
87-
add_compile_definitions( _GLIBCXX_ASSERTIONS )
88-
add_compile_definitions( _USE_MATH_DEFINES )
89-
if ( DEFINED VERSION )
90-
add_compile_definitions( VERSION="${VERSION}" )
91-
endif()
79+
# 'add_compile_definitions()' was introduced with CMake 3.12
80+
add_compile_definitions( _GLIBCXX_ASSERTIONS )
81+
add_compile_definitions( _USE_MATH_DEFINES )
82+
if ( DEFINED VERSION )
83+
add_compile_definitions( VERSION="${VERSION}" )
9284
endif()
9385

9486
# show all compile options and definitions

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ Every commit triggers a workflow on
9797
[GitHub Actions](https://github.com/OpenHantek/OpenHantek6022/actions/workflows/build_check.yml)
9898
that builds and packages OpenHantek6022 for:
9999
* Linux (`*.deb`, `*.rpm`, `*.tar.gz`)
100-
* Windows (`*_mingw_x64.zip`, `*_msvc_x64.zip`)
101-
* macOS - (`*.dmg`, `*.tar.gz`)
100+
* Windows (<!--`*_mingw_x64.zip`, -->`*_msvc_x64.zip`)
101+
* macOS - (`*_osx_arm64.dmg`, `*_osx_x86_64.dmg`, `*.tar.gz`)
102102

103103
[![GitHub CI](https://github.com/OpenHantek/OpenHantek6022/actions/workflows/build.yml/badge.svg)](https://github.com/OpenHantek/OpenHantek6022/actions/workflows/build.yml)
104104
This status badge here (and on top) show the build status.
@@ -111,7 +111,7 @@ The easiest way to get an up-to-date working code base is to clone the code from
111111
````git clone https://github.com/OpenHantek/OpenHantek6022.git````
112112

113113
and then build it locally, for this you will need the following software:
114-
* [CMake 3.10+](https://cmake.org/download/)
114+
* [CMake 3.12+](https://cmake.org/download/)
115115
* [Qt 6.2+](https://www1.qt.io/download-open-source/)
116116
* [FFTW 3+](http://www.fftw.org/) (prebuild files will be downloaded on windows)
117117
* [libusb-1.0](https://libusb.info/), version >= 1.0.16 (prebuild files will be used on windows)

openhantek/src/mainwindow.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ MainWindow::MainWindow( HantekDsoControl *dsoControl, DsoSettings *settings, Exp
526526
+ tr( "<p>Graphic: %1 - GLSL version %2</p>"
527527
"<p>Qt version: %3</p>" )
528528
.arg( GlScope::getOpenGLversion(), GlScope::getGLSLversion(), // graphic info
529-
QT_VERSION_STR ) + // Qt version info
529+
qVersion() ) + // Qt lib version info
530530
tr( "<p>Running since %1 seconds.</p>" ).arg( elapsedTime.elapsed() / 1000 ) );
531531
} );
532532

0 commit comments

Comments
 (0)