Merge pull request #129 from OpenIPC/dev

move ping message to Debug writeline, fix FirmwareTab unit test

Author: mikecarr

OpenIPC_Config.Tests/ViewModels/FirmwareTabViewModelTests.cs

@@ -17,6 +17,7 @@ public class FirmwareTabViewModelTests
     private Mock<ISshClientService> _mockSshClientService;
     private Mock<IEventSubscriptionService> _mockEventSubscriptionService;
     private Mock<IGitHubService> _mockGithubService;
+    private Mock<IMessageBoxService> _mockMessageBoxService;
 
     [SetUp]
     public void Setup()
@@ -26,13 +27,15 @@ public void Setup()
 
         _mockSshClientService = new Mock<ISshClientService>();
         _mockEventSubscriptionService = new Mock<IEventSubscriptionService>();
-        _mockGithubService = new Mock<IGitHubService>(); 
+        _mockGithubService = new Mock<IGitHubService>();
+        _mockMessageBoxService = new Mock<IMessageBoxService>();
 
         _viewModel = new FirmwareTabViewModel(
             _mockLogger.Object,
             _mockSshClientService.Object,
             _mockEventSubscriptionService.Object,
-            _mockGithubService.Object);
+            _mockGithubService.Object,
+            _mockMessageBoxService.Object);
     }
 
 

OpenIPC_Config/ViewModels/FirmwareTabViewModel.cs

@@ -42,7 +42,7 @@ public partial class FirmwareTabViewModel : ViewModelBase
     private readonly IGitHubService _gitHubService;
     private bool _bInitializedCommands = false;
     private bool _bRecursionSelectGuard = false;
-    IMessageBoxService _messageBoxService;
+    private readonly IMessageBoxService _messageBoxService;
     #endregion
 
     #region Observable Properties

OpenIPC_Config/ViewModels/MainViewModel.cs

@@ -380,7 +380,7 @@ private async void PingTimer_Tick(object? sender, EventArgs e)
                 // Only update the UI state if the IP we pinged is still the current IP
                 if (ipBeingPinged == IpAddress)
                 {
-                    _logger.Error(pingEx, $"Error occurred during ping to {ipBeingPinged}");
+                    Debug.WriteLine(pingEx, $"Error occurred during ping to {ipBeingPinged}");
                     IsConnected = false;
                     IsWaiting = true;
                     _logger.Verbose("Current state after exception: IsConnected=False, IsWaiting=True");
@@ -391,7 +391,7 @@ private async void PingTimer_Tick(object? sender, EventArgs e)
                 }
             }
 
-            _logger.Verbose($"After ping to {ipBeingPinged}: IsConnected={IsConnected}, IsWaiting={IsWaiting}");
+            Debug.WriteLine($"After ping to {ipBeingPinged}: IsConnected={IsConnected}, IsWaiting={IsWaiting}");
         }
         catch (Exception ex)
         {