OLA Trigger tidying and improvements #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Don't we need this to tell you which line the error occurs on?
Member
Author
There was a problem hiding this comment.
I found with this in place, the line numbers were wrong; with it removed, they were correct. It's probably worth testing on some other OSes though.
I think we could remove our yywrap function too, and just use the noyywrap option if it's present in old enough releases.
Member
Author
|
Thanks for the comments @nomis52 . This is blocking on #1014 (comment) in #1014 though. |
Member
Author
|
@nomis52 do you want to merge this if you're happy? |
Member
|
LGTM |
nomis52
added a commit
that referenced
this pull request
Jan 31, 2016
OLA Trigger tidying and improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.