Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
980ea41
Check if the device exists before bothering to try to acquire a lock …
peternewman Jan 10, 2016
6c1cca3
Merge pull request #1010 from peternewman/debian
nomis52 Jan 11, 2016
e5b4e15
Update NEWS
peternewman Jan 23, 2016
3516757
Merge branch '0.10' into debian
peternewman Jan 23, 2016
fa3c854
Start fixing flake8 issues(cherry picked from commit b5c881e93963c7ac…
peternewman Jan 14, 2016
6caed96
Skip "E114 indentation is not a multiple of four (comment)"
peternewman Jan 14, 2016
61cdc6f
Start fixing flake8 issues(cherry picked from commit f839779996b7023b…
peternewman Jan 14, 2016
18c8ecf
Start fixing flake8 issues(cherry picked from commit 28a87a8bb7b42c80…
peternewman Jan 14, 2016
ace2d21
Start fixing flake8 issues(cherry picked from commit 88cf0d422d0c0c3f…
peternewman Jan 14, 2016
6b7b0b0
Start fixing flake8 issues(cherry picked from commit d3daa43951edf373…
peternewman Jan 14, 2016
f41ce42
Start fixing flake8 issues(cherry picked from commit 1991ba6c24646a71…
peternewman Jan 14, 2016
ef97e6f
Start fixing flake8 issues(cherry picked from commit a3f3bf93004ee8f9…
peternewman Jan 14, 2016
17383ba
Start fixing flake8 issues(cherry picked from commit 57052346eddeafcf…
peternewman Jan 14, 2016
015995d
Start fixing flake8 issues(cherry picked from commit f66651a263466799…
peternewman Jan 14, 2016
0e9c64a
Fixing more new flake8 issues(cherry picked from commit de5b3e36383e4…
peternewman Jan 14, 2016
32e4d9e
Fixing more new flake8 issues(cherry picked from commit 102f60f404bcd…
peternewman Jan 14, 2016
1da80a1
Fixing more new flake8 issues(cherry picked from commit 15652448439a8…
peternewman Jan 14, 2016
b170766
Fixing more new flake8 issues(cherry picked from commit 1a2303979a26d…
peternewman Jan 14, 2016
ae2dc9b
Fixing more new flake8 issues(cherry picked from commit d02fe4160510d…
peternewman Jan 14, 2016
1c20ad5
Fixing more new flake8 issues(cherry picked from commit e46a3b65af3f2…
peternewman Jan 14, 2016
d39f28c
Fixing more new flake8 issues(cherry picked from commit 3f514107ed07d…
peternewman Jan 14, 2016
3016211
Fixing more new flake8 issues(cherry picked from commit 9368efb0c0f6e…
peternewman Jan 14, 2016
ee1f006
Fixing more new flake8 issues(cherry picked from commit efe33248f6200…
peternewman Jan 14, 2016
afc90fd
Fixing more new flake8 issues(cherry picked from commit c61972c3d2de3…
peternewman Jan 14, 2016
425c6f5
Update StreamRpcChannel.py(cherry picked from commit 279843676070b201…
peternewman Jan 14, 2016
c8623ab
Fixing more new flake8 issues(cherry picked from commit ca4df53485e4f…
peternewman Jan 14, 2016
766f118
Fixing more new flake8 issues(cherry picked from commit ab8f30181daf8…
peternewman Jan 14, 2016
6fc06d6
Fixing more new flake8 issues(cherry picked from commit 73882dd146a79…
peternewman Jan 14, 2016
09b2aae
Fixing more new flake8 issues(cherry picked from commit 66e577ccecc96…
peternewman Jan 14, 2016
1c52b0b
Fixing more new flake8 issues(cherry picked from commit 64a79327e833e…
peternewman Jan 14, 2016
2318c7c
Fixing more new flake8 issues(cherry picked from commit 161eab9510571…
peternewman Jan 14, 2016
6bf0aa7
Fixing more new flake8 issues(cherry picked from commit cd0e1904f75f7…
peternewman Jan 14, 2016
7587659
Fixing more new flake8 issues(cherry picked from commit a4c2d145a02b8…
peternewman Jan 14, 2016
01a76ba
Fixing more new flake8 issues(cherry picked from commit 5f72eff1a0c91…
peternewman Jan 14, 2016
5730358
Try and fix the line break before a binary operator error(cherry pick…
peternewman Jan 19, 2016
e3311cc
Fix the whitespace error(cherry picked from commit 7a343f2236d97ca848…
peternewman Jan 19, 2016
e333b30
Try and fix the line break before a binary operator error(cherry pick…
peternewman Jan 19, 2016
57e40cb
Fix the outstanding lambda issues
peternewman Jan 23, 2016
1b8ba6b
Fix trailing whitespace(cherry picked from commit 472857af651d945187a…
peternewman Jan 23, 2016
1aab307
Fix trailing whitespace(cherry picked from commit e0e016c2ab1c0e26565…
peternewman Jan 23, 2016
1c1d6a0
Fix up the file
peternewman Jan 8, 2016
68efa5a
Fix up the file
peternewman Jan 8, 2016
af571df
Allow more code to be imported(cherry picked from commit 20f76b5cf100…
peternewman Jan 1, 2016
7596eb2
Allow more code to be imported(cherry picked from commit c859d505415b…
peternewman Jan 1, 2016
69463b0
Fix more pychecker issues
peternewman Jan 8, 2016
542a070
Merge pull request #1016 from peternewman/debian
peternewman Jan 26, 2016
de3fa35
Merge branch '0.10' of https://github.com/OpenLightingProject/ola int…
peternewman Jan 26, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ x/y/2016 ola-0.10.1
*

Bugs:
*
* Check if a device exists before trying to acquire a UUCP lock file for it #1006

Internal:
*
Expand Down
9 changes: 8 additions & 1 deletion common/io/Serial.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,14 @@ bool AcquireUUCPLockAndOpen(const std::string &path, int oflag, int *fd) {
// If it was only a single process doing the locking we could use fnctl as
// described in 55.6 of the Linux Programing Interface book.

// First, clean up a stale lockfile.
// First, check if the path exists, there's no point trying to open it if not
if (!FileExists(path)) {
OLA_INFO << "Device " << path << " doesn't exist, so there's no point "
"trying to acquire a lock";
return false;
}

// Second, clean up a stale lockfile.
const string lock_file = GetLockFile(path);
OLA_DEBUG << "Checking for " << lock_file;
pid_t locked_pid;
Expand Down