Make DNS-SD functionality optional at build time. #1061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure.ac
Outdated
| [AC_DEFINE([HAVE_AVAHI], [1], [Defined to use Avahi])]) | ||
| AM_CONDITIONAL([HAVE_AVAHI], [test "x$have_avahi" = xyes]) | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Can you remove the extra blank lines please.
Member
|
Do you want to target 0.10 @bk138 , then this will get into 0.10.2 when we release it? |
When building for embedded systems, for instance, we want to limit dependencies to a minimum and it seems that OLA is able to perform its core tasks without DNS-SD perfectly fine. Signed-off-by: Christian Beier <[email protected]>
Contributor
Author
|
@peternewman removed the blank lines. And yes, I'd like this to go in ASAP ;-) |
Member
|
You'll need to open a new PR targetting our 0.10 branch then please @bk138 . |
Contributor
Author
|
Done. See #1062. Do you cherry-pick that to master or merge this PR here as well? |
Member
|
I'll close this one, we merge 0.10 into master on a fairly regular basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for embedded systems, for instance, we
want to limit dependencies to a minimum and it seems
that OLA is able to perform its core tasks without
DNS-SD perfectly fine.
Signed-off-by: Christian Beier [email protected]