Yocto recipe for building ola on any embedded device supported. #1409

arielmol · 2018-04-25T19:19:08Z

Tested with rocko.

…d with rocko.

arielmol · 2018-04-25T20:43:22Z

So strange it did not build, my code does not even require to be compiled. It's basically a yocto recipe just for reference.

peternewman · 2018-04-25T21:23:51Z

If you read why it's failing:
https://travis-ci.org/OpenLightingProject/ola/jobs/371260377#L7175

+./scripts/verify_trees.py ./ ola-0.10.6
Missing from tarball yocto/recipes-conectivity/ola/ola_git.bb
---------------------------------------
Either add the missing files to the appropriate Makefile.mk
or update IGNORE_PATTERNS in scripts/verify_trees.py
---------------------------------------

So you need to probably add a Makefile for that directory and add it to that.

peternewman

A few comments on the build script.

peternewman · 2018-04-25T21:29:48Z

yocto/recipes-conectivity/ola/ola_git.bb

+
+PV = "0.10.6"
+
+# Esta revision de git tiene un parche para protobuf, la tag de 0.10.6 no compila.


Could we have this comment in English please :)

peternewman · 2018-04-25T21:30:42Z

yocto/recipes-conectivity/ola/ola_git.bb

+LICENSE = "GPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://LICENCE;md5=7aa5f01584d845ad733abfa9f5cad2a1"
+
+#DEPENDS_class-nativesdk = "bison libusb1 protobuf protobuf-native pkgconfig-native ossp-uuid ola-native "


Is this relevant still? Would this be for a native build?

UPDATED: Read below

That line is optional for when you need an sdk

Should it be uncommented though then, there seems to be a mix of both referring to nativesdk throughout the file.

peternewman · 2018-04-25T21:40:32Z

yocto/recipes-conectivity/ola/ola_git.bb

+
+# target    are the real config options
+EXTRA_OECONF_append_class-target = " --with-ola-protoc-plugin=${STAGING_BINDIR_NATIVE}/ola_protoc_plugin --disable-python-libs\
+  --enable-http     --enable-dummy            --enable-gpio   --enable-opendmx --enable-e131 \


You don't explicitly need to enable all the options. Although it will ensure configure fails if some of them aren't available for some reason.

In yocto anyone would be able to disable them, but disabling them will make ola build transparently but be useless as will have no plugins.

Okay, if we need to explicitly enable all plugins in here we ought to add a note to ensure we add new ones here when they're added to https://github.com/OpenLightingProject/ola/blob/d34d4f13d954894e76bf024743e6519696813c29/configure.ac#L892-915

peternewman · 2018-04-25T21:45:52Z

yocto/recipes-conectivity/ola/ola_git.bb

+CXXFLAGS = "${CFLAGS}"
+
+# The code is not Werror safe
+do_configure_prepend() {


--disable-fatal-warnings will do this, without needing to be quite so hacky. Although we try our best to fix the issues, so ideally can you tell us what errors you're getting and we'll try and fix or bypass them before they become critical in future.

You mean as an argument for ./configure ?

Correct @desert .

But please either comment here, or pastebin the errors and we can try adn fix them properly.

arielmol · 2018-04-25T22:27:43Z

So you need to probably add a Makefile for that directory and add it to that.

Oh, I know nothing about autotools.

peternewman · 2018-05-17T13:10:49Z

So you need to probably add a Makefile for that directory and add it to that.

Oh, I know nothing about autotools.

That's easy, see the Debian one here:
https://github.com/OpenLightingProject/ola/blob/master/debian/Makefile.mk

And then the new Makefile.mk needs including in the master Makefile.am:
https://github.com/OpenLightingProject/ola/blob/master/Makefile.am#L153

peternewman

Some updated comments/re-review.

peternewman · 2023-06-11T20:29:02Z

yocto/recipes-conectivity/ola/ola_git.bb

+PV = "0.10.6"
+
+# 0.10.6 tag won't build, this rev has protobuf patches
+SRCREV = "00dc86a48ec4c528cec90166435b440f283a9c86" 
+SRC_URI = "git://github.com/OpenLightingProject/ola.git;protocol=https"


We should be able to build 0.10.9 cleanly now, is this the right sort of syntax?

Suggested change

PV = "0.10.6"

# 0.10.6 tag won't build, this rev has protobuf patches

SRCREV = "00dc86a48ec4c528cec90166435b440f283a9c86"

SRC_URI = "git://github.com/OpenLightingProject/ola.git;protocol=https"

PV = "0.10.9"

SRC_URI = "git://github.com/OpenLightingProject/ola.git;protocol=https"

peternewman · 2023-06-11T20:32:00Z

yocto/recipes-conectivity/ola/ola_git.bb

+LICENSE = "GPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://LICENCE;md5=7aa5f01584d845ad733abfa9f5cad2a1"
+
+#DEPENDS_class-nativesdk = "bison libusb1 protobuf protobuf-native pkgconfig-native ossp-uuid ola-native "


Should it be uncommented though then, there seems to be a mix of both referring to nativesdk throughout the file.

peternewman · 2023-06-11T20:32:48Z

yocto/recipes-conectivity/ola/ola_git.bb

+
+inherit autotools-brokensep relative_symlinks
+# autotools-brokensep 
+# forces in-source building (ola has bugs for out-of-tree builds). 


I think/hope we've fixed this too now...

peternewman · 2023-06-11T20:34:11Z

yocto/recipes-conectivity/ola/ola_git.bb

+# inherit relative_symlinks within the recipe to turn those absolute symlinks into relative
+# https://www.yoctoproject.org/docs/2.4/ref-manual/ref-manual.html#migration-2.3-absolute-symlinks
+
+#EXTRA_OECONF = " --disable-unittests --disable-rdm-tests --disable-python-libs --disable-java-libs --disable-all-plugins"


Is this line redundant/part of testing?

peternewman · 2023-06-11T20:36:57Z

yocto/recipes-conectivity/ola/ola_git.bb

+
+# target    are the real config options
+EXTRA_OECONF_append_class-target = " --with-ola-protoc-plugin=${STAGING_BINDIR_NATIVE}/ola_protoc_plugin --disable-python-libs\
+  --enable-http     --enable-dummy            --enable-gpio   --enable-opendmx --enable-e131 \


Okay, if we need to explicitly enable all plugins in here we ought to add a note to ensure we add new ones here when they're added to https://github.com/OpenLightingProject/ola/blob/d34d4f13d954894e76bf024743e6519696813c29/configure.ac#L892-915

arielmol added 2 commits April 25, 2018 14:18

Yocto recipe for building ola on any embedded device supported. Teste…

6441e8e

…d with rocko.

Fix typo

af62631

peternewman requested changes Apr 25, 2018

View reviewed changes

Correct lang for comment

f42252c

peternewman added this to the 0.11.0 milestone Jul 28, 2018

peternewman reviewed Jun 11, 2023

View reviewed changes

peternewman mentioned this pull request Jun 11, 2023

Is there a recipe for yocto building? #1398

Open


		PV = "0.10.6"

		# Esta revision de git tiene un parche para protobuf, la tag de 0.10.6 no compila.

Yocto recipe for building ola on any embedded device supported. #1409

Are you sure you want to change the base?

Yocto recipe for building ola on any embedded device supported. #1409

Uh oh!

Conversation

arielmol commented Apr 25, 2018

Uh oh!

arielmol commented Apr 25, 2018

Uh oh!

peternewman commented Apr 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arielmol Apr 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arielmol commented Apr 25, 2018

Uh oh!

peternewman commented May 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

peternewman commented Apr 25, 2018 •

edited

Loading

arielmol Apr 25, 2018 •

edited

Loading

peternewman commented May 17, 2018 •

edited

Loading