Properly close socket on destruction of OlaClient #1482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a program using
ola.ClientWrapperis run withpython -Wallon Python 3, the interpreter prints aResourceWarningcomplaining about an unclosed socket.This PR fixes that warning.
For example, if you run:
cd python python3 -Wall examples/ola_send_dmx.pyYou will get:
With the proposed fix, the
ResourceWarningdisappears.