UsbPro Extended Device/Widget #1573
Conversation
Revert "added DMX frame padding" This reverts commit cdb1200.
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
Can you separate the USBPro stuff out into a new PR (or the UART stuff), also see this PR which I'd be more inclined to accept as it's more generic:
#1563
| UIntValidator(8, 1000000), | ||
| DEFAULT_MALF); | ||
| save |= m_preferences->SetDefaultValue(DevicePaddingKey(), | ||
| UIntValidator(24, 512), |
There was a problem hiding this comment.
Is this data slots, or including start code? I think in theory it can be less than 24 depending on frame rate etc.
There was a problem hiding this comment.
This is data slots. Got this number somewhere on net.
Wikipedia: However, it does require that packets be transmitted so that the leading edges of any two sequential BREAKs must be separated by at least 1204 μs, and receivers must be able to handle packets with break-to-break times as short as 1196 μs.[10] The minimum break-to-break transmit time can be achieved by sending packets that contain at least 24 slots
| using std::vector; | ||
|
|
||
| UartWidget::UartWidget(const string& path) | ||
| UartWidget::UartWidget(const std::string &path, unsigned int padding) |
There was a problem hiding this comment.
You don't need the std:: as we're already using string.
| UartWidget::UartWidget(const string& path) | ||
| UartWidget::UartWidget(const std::string &path, unsigned int padding) | ||
| : m_path(path), | ||
| m_padding (padding), |
There was a problem hiding this comment.
Align with the line above and below (and drop the space before ()
|
|
||
| private: | ||
| const std::string m_path; | ||
| const std::string m_path; |
There was a problem hiding this comment.
Can you leave the indenting where it was, two in from the start of the line.
I.e. make a new branch for new PR? |
2 participants
Extention to Ennec message labels
ESTA ID = 0x7FF7 Experimental
DEVICE ID = i/o port count combined in uint16_t
LABELS = 100 + m_port_id
NOTE: in Port class m_port_id is private, had to make m_port_id_ext instead