Adding ovdmx support for ola #1581
Conversation
…ust the stability of this just yet
…iage return in the byte stream. Was very annoying to debug...
…nks to Oeystein for the fix.
In terms of the hardware, can you give some more info? My gut feeling is you're probably in the right area making a new plugin, but see some other options here: So fixing the licence check would be an excellent and trivial place to start. |
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
Please fix the lint and licence checker issues on Travis:
https://travis-ci.org/OpenLightingProject/ola/jobs/584338565#L1635-L1642
https://travis-ci.org/OpenLightingProject/ola/jobs/584338566#L1041-L1045
|
Sorry this took a lot longer than I anticipated, kind of forgot it with everything that happened these last few years. I have made the changes you suggested and hope everything is okey now. Regarding the hardware it is custom with a pcb layout and microcontroller code which you can find here https://github.com/omegav/ovdmx |
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
Some initial comments.
Is there anything special to identify your device via lsusb, or is it just on /dev/ttyACM0 or similar?
plugins/ovdmx/OVDmxThread.cpp
Outdated
| dmx_packet.data_length_parts[0] = ((((uint16_t)DMX_UNIVERSE_SIZE)>>8) & 0xff); | ||
| dmx_packet.data_length_parts[1] = ((((uint16_t)DMX_UNIVERSE_SIZE)) & 0xff); |
There was a problem hiding this comment.
Have a look at our SplitUInt16 function for this.
What happens if the incoming DMX frame has fewer than 512 slots?
There was a problem hiding this comment.
I'm unsure, in the application I have used it in there has always been 512 frames afaik. The original author of the code @JanOveSaltvedt could probably comment on that
I have changed it at least to SplitUInt16 as requested.
From my understanding it just shows up as /dev/ttyACM0 since it's configured on the MCU side to show up as a usb cdc device. You can see the MCU usb config here https://github.com/omegav/ovdmx/blob/master/Code/OVDMX/src/config/conf_usb.h |
De-dented Co-authored-by: Peter Newman <[email protected]>
attached comment to function Co-authored-by: Peter Newman <[email protected]>
Aligned Co-authored-by: Peter Newman <[email protected]>
Fixed typo Co-authored-by: Peter Newman <[email protected]>
Fixes aligning Co-authored-by: Peter Newman <[email protected]>
|
All the changes you requested should now be committed |
4 participants
Created a new pull request, we would also like to add some references to the hardware files so people can also make their own adapters