-
Notifications
You must be signed in to change notification settings - Fork 221
Add Nortle as a FDTI adaptor manufacturer #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Im selling openscource FDTI adaptors under the name NORTLE i would like these to be compatible with OLA |
|
So these are the same as the OpenDMX USB, no microprocessor onboard, effectively just a re-titled FTDI? |
peternewman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment.
You could also target our 0.10 branch if you want to get it out sooner?
| std::string::npos != v.find("WWW.SOH.CZ")) { | ||
| std::string::npos != v.find("WWW.SOH.CZ") || | ||
| std::string::npos != v.find("NORTLE")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sort the order of the manufacturers please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by sort manufacturers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in WWW.SOH.CZ > NORTLE, the string comparisons.
|
yes these are the same as the opendmxusb but are available with up to a 4 port version it can definitely be moved to the 0.10 branch |
Great, you'll need to cherry-pick or rebase or something. |
|
Have you had any more time to look at this @arneman44 ? |
No description provided.