Skip to content

Conversation

@arneman44
Copy link

No description provided.

@arneman44
Copy link
Author

Im selling openscource FDTI adaptors under the name NORTLE i would like these to be compatible with OLA

@peternewman
Copy link
Member

So these are the same as the OpenDMX USB, no microprocessor onboard, effectively just a re-titled FTDI?

Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment.

You could also target our 0.10 branch if you want to get it out sooner?

Comment on lines -195 to +196
std::string::npos != v.find("WWW.SOH.CZ")) {
std::string::npos != v.find("WWW.SOH.CZ") ||
std::string::npos != v.find("NORTLE")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sort the order of the manufacturers please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by sort manufacturers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in WWW.SOH.CZ > NORTLE, the string comparisons.

@arneman44
Copy link
Author

yes these are the same as the opendmxusb but are available with up to a 4 port version

it can definitely be moved to the 0.10 branch

@peternewman
Copy link
Member

it can definitely be moved to the 0.10 branch

Great, you'll need to cherry-pick or rebase or something.

@peternewman
Copy link
Member

Have you had any more time to look at this @arneman44 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants