Skip to content

Conversation

@peternewman
Copy link
Member

At leas this file is missing and means that when you make install it fails to run the RDM tests. There's a chance we've missed other files too, so ideally we'd check that (e.g. from 0.10.8 to 0.10.9 and go from there...)

@peternewman peternewman added this to the 0.10.10 milestone Mar 8, 2023
@peternewman peternewman requested a review from kripton March 8, 2023 16:15
Copy link
Member

@kripton kripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the list of files in the Makefile with the list of files existing and cannot find any more discrepancies

@DaAwesomeP
Copy link
Member

Funnily enough, I was running into this exactly in #1812 and thought it was a Python 2 vs 3 library location issue.

@peternewman peternewman merged commit ed78841 into OpenLightingProject:0.10 Mar 11, 2023
@peternewman
Copy link
Member Author

I've reviewed the list of files in the Makefile with the list of files existing and cannot find any more discrepancies

Great thanks @kripton . I also looked at 0.10.8...0.10.9 and the only other new Python files are tests and examples, neither of which we currently install.

Funnily enough, I was running into this exactly in #1812 and thought it was a Python 2 vs 3 library location issue.

Sorry to hear that @DaAwesomeP . You can update now and maybe this will be enough to fix it.

This was mostly a lack of CI and a bit of me not testing anymore than make/make check.

@DaAwesomeP
Copy link
Member

Sorry to hear that @DaAwesomeP . You can update now and maybe this will be enough to fix it.

I'll give it a go tomorrow! That might fully fix the Debian 11 (bullseye) check steps.

This was mostly a lack of CI and a bit of me not testing anymore than make/make check.

No worries! I'm really excited about the general uptick in movement with the project at the moment. Everything is just getting better!

@peternewman
Copy link
Member Author

Sorry to hear that @DaAwesomeP . You can update now and maybe this will be enough to fix it.

I'll give it a go tomorrow! That might fully fix the Debian 11 (bullseye) check steps.

🤞

This was mostly a lack of CI and a bit of me not testing anymore than make/make check.

No worries! I'm really excited about the general uptick in movement with the project at the moment. Everything is just getting better!

Yeah its churning along at the moment compared to the last year say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS: 0.10.9_1 (latest brew upgrade) : ModuleNotFoundError: No module named 'ola.StringUtils': 0.10.9_1 (brew install) :

3 participants