Merge branch 'fix_delete_game_ub' into 'master'

Avoid accessing removed character on deleting last save (#8387)

Closes #8387

See merge request OpenMW/openmw!4574

Author: Capostrophic

apps/openmw/mwstate/charactermanager.cpp

@@ -38,7 +38,7 @@ MWState::Character* MWState::CharacterManager::getCurrentCharacter()
     return mCurrent;
 }
 
-void MWState::CharacterManager::deleteSlot(const MWState::Character* character, const MWState::Slot* slot)
+void MWState::CharacterManager::deleteSlot(const MWState::Slot* slot, const MWState::Character*& character)
 {
     std::list<Character>::iterator it = findCharacter(character);
 
@@ -51,6 +51,7 @@ void MWState::CharacterManager::deleteSlot(const MWState::Character* character,
         if (character == mCurrent)
             mCurrent = nullptr;
         mCharacters.erase(it);
+        character = nullptr;
     }
 }
 

apps/openmw/mwstate/charactermanager.hpp

@@ -33,7 +33,7 @@ namespace MWState
         Character* getCurrentCharacter();
         ///< @note May return null
 
-        void deleteSlot(const MWState::Character* character, const MWState::Slot* slot);
+        void deleteSlot(const MWState::Slot* slot, const Character*& character);
 
         Character* createCharacter(const std::string& name);
         ///< Create new character within saved game management

apps/openmw/mwstate/statemanagerimp.cpp

@@ -706,10 +706,10 @@ void MWState::StateManager::quickLoad()
 void MWState::StateManager::deleteGame(const MWState::Character* character, const MWState::Slot* slot)
 {
     const std::filesystem::path savePath = slot->mPath;
-    mCharacterManager.deleteSlot(character, slot);
+    mCharacterManager.deleteSlot(slot, character);
     if (mLastSavegame == savePath)
     {
-        if (character->begin() != character->end())
+        if (character != nullptr)
             mLastSavegame = character->begin()->mPath;
         else
             mLastSavegame.clear();