Skip to content

Commit 34c3dfe

Browse files
dg0ytdl3sdo
authored andcommitted
MapPart: Write 'hidden' XML attribute
Use negated logic to leverage our default behaviour of omitting false values. With this change, files with all parts visible remain unchanged. This fixes undesired changes to symbol sets, examples and test files.
1 parent 2a0335a commit 34c3dfe

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/core/map_part.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ namespace literal
4747
const QLatin1String objects("objects");
4848
const QLatin1String object("object");
4949
const QLatin1String count("count");
50-
const QLatin1String visibility("visibility");
50+
const QLatin1String hidden("hidden");
5151
}
5252

5353

@@ -95,7 +95,7 @@ void MapPart::save(QXmlStreamWriter& xml) const
9595
{
9696
XmlElementWriter part_element(xml, literal::part);
9797
part_element.writeAttribute(literal::name, name);
98-
part_element.writeAttribute(literal::visibility, visible);
98+
part_element.writeAttribute(literal::hidden, !visible);
9999
{
100100
XmlElementWriter objects_element(xml, literal::objects);
101101
objects_element.writeAttribute(literal::count, objects.size());
@@ -114,8 +114,7 @@ MapPart* MapPart::load(QXmlStreamReader& xml, Map& map, SymbolDictionary& symbol
114114

115115
XmlElementReader part_element(xml);
116116
auto part = new MapPart(part_element.attribute<QString>(literal::name), &map);
117-
if (part_element.hasAttribute(literal::visibility))
118-
part->visible = part_element.attribute<bool>(literal::visibility);
117+
part->visible = !part_element.attribute<bool>(literal::hidden);
119118

120119
while (xml.readNextStartElement())
121120
{

0 commit comments

Comments
 (0)