Importer: Don't explicitly delete placeholder

dg0yt · dg0yt · commit d775f6c40701 · 2020-06-13T06:06:23.000+02:00
Amends 9748301: Template object lifecycle is managed by smart pointers. Fixes GH-1656 (Crash when loading OCD files with templates). Credits to Libor.
diff --git a/src/fileformats/file_import_export.cpp b/src/fileformats/file_import_export.cpp
@@ -241,7 +241,6 @@ void Importer::validate()
 					view->setTemplateVisibility(temp, view->getTemplateVisibility(placeholder));
 					view->setTemplateLoadingBlocked(false);
 				}
-				delete placeholder;
 			}
 		}
 		

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,6 @@ void Importer::validate()`
`241`	`241`	`view->setTemplateVisibility(temp, view->getTemplateVisibility(placeholder));`
`242`	`242`	`view->setTemplateLoadingBlocked(false);`
`243`	`243`	`}`
`244`		`- delete placeholder;`
`245`	`244`	`}`
`246`	`245`	`}`
`247`	`246`