-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codeplug: Negative Geo Coordinates close to zero #40
Comments
Instead of using the current format for the coordinates, we can store them in Q1.15 or Q1.31 fixed point format, which one is better in terms of resolution. Another possibility is to use a Q8.24 format. Using 32 bit per coordinate we'll use 64 bit for lat. + lon. instead of 48, but is not a problem |
Proposal: use a signed 32 bit value for both longitude and latitude and store the values multiplied by 1000. That is: given a coordinate of 123.4567890°, store it as 1234567890 in an |
Updated the format used to store transmitter location: - removed the +500m offset for altitude, converted the value to a signed type - fix an error with negative coordinates close to zero, see #40.
This sounds good. You should change the factor to 1.000.000 in you commit, as intended to show 6 decimal places. |
Will do! |
The geo coordinates as described do not support negative coordinates close to 0, as an integer only has one value for 0.
A value like -0.09 N would become 0 for the integer part, which we can not differentiate.
The text was updated successfully, but these errors were encountered: