Skip to content

Modify init_sim! #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025
Merged

Modify init_sim! #204

merged 4 commits into from
Jun 12, 2025

Conversation

1-Bart-1
Copy link
Member

No description provided.

@1-Bart-1 1-Bart-1 linked an issue Jun 11, 2025 that may be closed by this pull request
3 tasks
@1-Bart-1 1-Bart-1 marked this pull request as ready for review June 11, 2025 19:58
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.07%. Comparing base (b423e4e) to head (2919dd3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ram_air_kite.jl 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   86.36%   86.07%   -0.30%     
==========================================
  Files           8        8              
  Lines        1819     1831      +12     
==========================================
+ Hits         1571     1576       +5     
- Misses        248      255       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two remarks.

@ufechner7
Copy link
Member

Relaxation is part of the Settings struct. The user should not do much programming anyways, the user should just modify Settings.yaml and run a simulation.

@1-Bart-1 1-Bart-1 merged commit 1fbf9ab into main Jun 12, 2025
8 of 10 checks passed
@1-Bart-1 1-Bart-1 deleted the modify-init branch June 12, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify init_sim!(s::RamAirKite, ...; ...)
2 participants