Skip to content

Offer recurring filters as declarative #1160

@MattiSG

Description

@MattiSG

Filters are used for many custom cleanup tasks, but some of those are recurring.
For example, parameter removal in href.
Studying the frequency of filters usage and the type of handling they do would provide us with ways to reduce their usage (which lowers maintenance costs) and enable more contribution to be done without JSON manipulation.

This could also lead to solving CVE NF-008.


Data collected by @clementbiron.

Filters usage

  • Total services: 726
  • Services with filters: 42
  • Proportion of services using filters: 5.78%

Filters types and distribution

  • remove url param: 19 occurences → use removeQueryParams built-in filter
  • replace content: 15 occurences (character replacement, add a DOM node, make an element clickable, ...)
  • remove content: 14 occurences
  • remove empty href attribute: 4 occurences
  • remove empty links: 3 occurences
  • add url param: 3 occurences
  • protect email: 3 occurences
  • remove attribute: 2 occurences
  • remove js links: 1 occurence
Filter name Service name Number of uses Type
cleanUrls Facebook 4 add url param
cleanUrls Facebook Payments 2 add url param
makePreviousVersionsLinksClickable Iberia 1 add url param
removeLabelAndSidFromUrls Booking.com 2 add url param
unifyEmailProtectedAddresses Cityscoot 1 protect email
unifyEmailProtectedAddresses Coffee Meets Bagel 1 protect email
unifyEmailProtectedAddresses Shockwave.com 1 protect email
removeAccordionLinks Brussels Airlines 2 remove attribute
removeAccordionsLinks Austrian Airlines AG 2 remove attribute
deleteReturnToTopOperator Galeries Lafayette 1 remove content
removeCountryVersion Blogger 1 remove content
removeCountryVersion Gmail 1 remove content
removeCountryVersion Google 1 remove content
removeCountryVersion Google Calendar 1 remove content
removeHelpButtons Facebook 1 remove content
removeHelpButtons Facebook Payments 1 remove content
removeImgFromCookiesPolicy Facebook 1 remove content
removeInvisibleText Bing 2 remove content
removeInvisibleText Microsoft 2 remove content
removeInvisibleText Microsoft Store 1 remove content
removeInvisibleText MSN 2 remove content
removeInvisibleText Skype 2 remove content
removeIrrelevantModulesFromPrivacyPolicy Bing 1 remove content
removeIrrelevantModulesFromPrivacyPolicy Microsoft 1 remove content
removeIrrelevantModulesFromPrivacyPolicy Microsoft Store 1 remove content
removeIrrelevantModulesFromPrivacyPolicy MSN 1 remove content
removeIrrelevantModulesFromPrivacyPolicy Skype 1 remove content
removeIrrelevantModulesFromTos Bing 1 remove content
removeIrrelevantModulesFromTos Microsoft 1 remove content
removeIrrelevantModulesFromTos MSN 1 remove content
removeIrrelevantModulesFromTos Skype 1 remove content
removeModuleIDs Bing 2 remove content
removeModuleIDs Microsoft 2 remove content
removeModuleIDs Microsoft Store 1 remove content
removeModuleIDs MSN 2 remove content
removeModuleIDs Skype 2 remove content
removeNavigationHeaders Bing 2 remove content
removeNavigationHeaders Microsoft 2 remove content
removeNavigationHeaders Microsoft Store 1 remove content
removeNavigationHeaders MSN 2 remove content
removeNavigationHeaders Skype 2 remove content
removeReturnToTopButtons Facebook 1 remove content
removeScripts Twitter 1 remove content
removeSecurityUpdates ASUS 1 remove content
removeEmptyAnchorsLinks Facebook 2 remove empty href attribute
removeEmptyLinks Decathlon 1 remove empty href attribute
removeEmptyLinks Iberia 1 remove empty href attribute
removeEmptyLinks Twitter 1 remove empty links
removeEmptySVGLinks Bitwarden 2 remove empty links
removeJavascriptLinks Vertbaudet 1 remove js links
cleanURLParams Disqus 2 remove url param
cleanUrls Facebook 4 remove url param
cleanUrls Facebook Payments 2 remove url param
removeAmpDeviceId Zoom 1 remove url param
removeFRZQueryParam Vertbaudet 1 remove url param
removeLabelAndSidFromUrls Booking.com 2 remove url param
removeLocaleFromUrls Facebook 2 remove url param
removePDFBlinkingQueryParam LOVOO 1 remove url param
removeSigfromUrls Booking.com 1 remove url param
removeTrackingIDs Facebook 2 remove url param
removeTrackingIDs Instagram 4 remove url param
removeUTMfromUrls AdSense 1 remove url param
removeUTMfromUrls Blogger 2 remove url param
removeUTMfromUrls Gmail 2 remove url param
removeUTMfromUrls Google 2 remove url param
removeUTMfromUrls Google Ads 1 remove url param
removeUTMfromUrls Google Analytics 1 remove url param
removeUTMfromUrls Google Calendar 1 remove url param
removeUTMfromUrls Google Voice 1 remove url param
removeUTMfromUrls Reserve with Google 1 remove url param
convertScriptToDiv WeChat Open Platform 1 replace content
correctTitleIndentation Facebook Payments 1 replace content
downloadImages Google Play 1 replace content
fixBrTag H&M 1 replace content
makePreviousVersionsLinksClickable Iberia 1 replace content
moveAppPrivacyPolicyIntoGlobalPrivacyPolicy LibraryThing 2 replace content
numberListCorrectly Facebook Payments 1 replace content
recoverReplacementCharacters Cdiscount 1 replace content
removeTitlesWhiteSpaces Galeries Lafayette 1 replace content
replaceAlmaImageLink Devred 1 replace content
replaceDaysAgo Yuka 1 replace content
replaceInfoImageWithEmoji Instagram 1 replace content
replaceNonBreakingSpaces Alibaba 2 replace content
stopImagesSourcesBlinking Vertbaudet 1 replace content
useXHelpCenterBaseURL X 7 replace content

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions